Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Removed dangling pubdate attributes #93

Merged
merged 1 commit into from

3 participants

@kwight
Owner

The attribute "pubdate" appears to no longer be part of the HTML5 spec, so remove them (they weren't being used anyways)

@kwight kwight Removed dangling pubdate attributes
The <time> attribute "pubdate" appears to no longer be part of the HTML5 spec, so remove them (they weren't being used anyways)
ca76e89
@lancewillett

I vote to leave them as is, discussing in a core ticket also: http://core.trac.wordpress.org/ticket/22095

@mfields

After reading the conclusion on the core ticket: http://core.trac.wordpress.org/ticket/22095 I think it may be best to follow core's example and drop the pubdate attribute from _s.

@mfields mfields merged commit 10c87ae into Automattic:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Oct 11, 2012
  1. @kwight

    Removed dangling pubdate attributes

    kwight authored
    The <time> attribute "pubdate" appears to no longer be part of the HTML5 spec, so remove them (they weren't being used anyways)
This page is out of date. Refresh to see the latest.
Showing with 2 additions and 2 deletions.
  1. +2 −2 inc/template-tags.php
View
4 inc/template-tags.php
@@ -93,7 +93,7 @@ function _s_comment( $comment, $args, $depth ) {
<?php endif; ?>
<div class="comment-meta commentmetadata">
- <a href="<?php echo esc_url( get_comment_link( $comment->comment_ID ) ); ?>"><time pubdate datetime="<?php comment_time( 'c' ); ?>">
+ <a href="<?php echo esc_url( get_comment_link( $comment->comment_ID ) ); ?>"><time datetime="<?php comment_time( 'c' ); ?>">
<?php
/* translators: 1: date, 2: time */
printf( __( '%1$s at %2$s', '_s' ), get_comment_date(), get_comment_time() ); ?>
@@ -123,7 +123,7 @@ function _s_comment( $comment, $args, $depth ) {
* @since _s 1.0
*/
function _s_posted_on() {
- printf( __( 'Posted on <a href="%1$s" title="%2$s" rel="bookmark"><time class="entry-date" datetime="%3$s" pubdate>%4$s</time></a><span class="byline"> by <span class="author vcard"><a class="url fn n" href="%5$s" title="%6$s" rel="author">%7$s</a></span></span>', '_s' ),
+ printf( __( 'Posted on <a href="%1$s" title="%2$s" rel="bookmark"><time class="entry-date" datetime="%3$s">%4$s</time></a><span class="byline"> by <span class="author vcard"><a class="url fn n" href="%5$s" title="%6$s" rel="author">%7$s</a></span></span>', '_s' ),
esc_url( get_permalink() ),
esc_attr( get_the_time() ),
esc_attr( get_the_date( 'c' ) ),
Something went wrong with that request. Please try again.