Skip to content

Change .tag-links to .tags-links #94

Merged
merged 1 commit into from Oct 24, 2012

4 participants

@sixhours

Using the class .tag-links may cause a rare formatting bug. To reproduce:

  1. Publish a new post and tag it "links"
  2. post_class() assigns the class .tag-links to the post
  3. Any formatting applied to .tag-links in the theme's stylesheet will also apply to this post -- not good!

Changing the class name to something that won't conflict, like .tags-links, should solve this problem.

@sixhours sixhours Change .tag-links to .tags-links
Using the class .tag-links may cause a rare formatting bug. To reproduce:

1. Publish a new post and tag it "links"
2. post_class() assigns the class .tag-links to the post
3. Any formatting applied to .tag-links in the theme's stylesheet will also apply to this post -- not good!

Changing the class name to something that won't conflict, like .tags-links, should solve this problem.
c7f0e44
@ianstewart ianstewart merged commit 152ae26 into Automattic:master Oct 24, 2012
@mfields
mfields commented Oct 24, 2012

Crazy! Great catch! Lately, I've been experimenting with the idea of .entry-tags and .entry-categories to me more consistent with the other entry-* classes.

@mtias
Automattic member
mtias commented Oct 24, 2012

Oh, yes, .entry-tags sounds nice and easy to remember.

@sixhours

I agree @mfields, .entry-tags and .entry-categories would be easier to remember!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.