Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Change the search form text input to type search #98

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
5 participants

you probably have a good reason that the theme doesn't use it already,
but I just thought I'd suggest it.

change input type from text to search
you probably have a good reason that the theme doesn't use it already,
but I just thought I'd suggest it.
Collaborator

grappler commented Nov 28, 2012

Contributor

mfields commented Nov 30, 2012

@grappler Thanks for the link, but it looks like that article is a bit dated at this point. The following styles were listed in the article as not-working:

input[type=search] { 
    color: red;  
    text-align: right;
    cursor: pointer;
    display: block; 
    width: 100%; 
    letter-spacing: 4px;        
    text-shadow: 0 0 2px black;       
    word-spacing: 20px;               
}

I tested them all in the stable versions of Chrome and Safari as well as the latest Webkit nightly. All work for me. I definitely like how these browsers add a little "clear search form" button. Unless there are serious issues that I am overlooking, I think this is a good one to merge.

cool thanks Mike

Member

iamtakashi commented Feb 27, 2013

I also like the first change from @pdewouters but then we should add the basic style for it like other input elements.

Collaborator

philiparthurmoore commented Feb 27, 2013

We should probably open another ticket that proposes style additions to search input types. Simply changing the input type to search doesn't seem like enough and there's a stack of commits loaded onto this Issue that makes merging it difficult.

lancewillett added a commit to lancewillett/_s that referenced this pull request Feb 27, 2013

Search form improvements, see also #98 for search type
- Add "searchform" class to form element, easier styling
- Better gettext for label, placeholder, and submit text, easier for translators
- Remove "name" attribute from submit button, not needed -- and adds cruft to URL
Collaborator

philiparthurmoore commented Feb 27, 2013

Closing. Fixed in Issue #166.

oh well, I guess my photo won't be on the underscores.me home page then ;)

Collaborator

philiparthurmoore commented Feb 27, 2013

You're on the home page of my theming heart, if that helps. Please keep contributing, in all seriousness. We had to go with @iamtakashi's commit because of the styling attached to it. Can't thank you enough for bringing these issues up, Paul.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment