Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change comment confirmation message based on approval settings #936

Closed
DavidCramer opened this issue Feb 6, 2018 · 2 comments
Closed

Change comment confirmation message based on approval settings #936

DavidCramer opened this issue Feb 6, 2018 · 2 comments
Projects
Milestone

Comments

@DavidCramer
Copy link
Contributor

DavidCramer commented Feb 6, 2018

As mentioned in #797 (comment) and #862 (comment)
The message indicated "..subject to moderation".
This message should be adjusted based on the moderation settings.
An indication of refresh times should also be mentioned.

@westonruter westonruter added this to the v0.7 milestone Feb 7, 2018
@westonruter
Copy link
Member

Code in question:

https://github.com/Automattic/amp-wp/blob/215860d618cc114d37f17f8efb477e6b5e3ccc40/includes/class-amp-theme-support.php#L360-L376

We should make the submit-success also contain a <template type="amp-mustache">. Then the message could say if the newly posted comment is actually moderated or not. Currently the success is just sent with success data without any data. But if this were changed to have a message like then the template can be added to render it.

In regards to the refresh time, we won't know what interval the amp-live-list is using in the theme. So if not moderated, then for now it should probably just say it will be available soon.

@DavidCramer DavidCramer self-assigned this Feb 7, 2018
@MackenzieHartung MackenzieHartung added this to To Do in v0.7 Mar 8, 2018
@DavidCramer DavidCramer moved this from To Do to In Progress in v0.7 Mar 12, 2018
@DavidCramer DavidCramer moved this from In Progress to Ready for Review in v0.7 Mar 15, 2018
@DavidCramer DavidCramer moved this from Ready for Review to In Progress in v0.7 Mar 19, 2018
@westonruter westonruter moved this from In Progress to Ready for Review in v0.7 Mar 21, 2018
@westonruter westonruter moved this from Ready for Review to QA in v0.7 Mar 21, 2018
@csossi
Copy link

csossi commented Mar 22, 2018

verified in QA (dev/paired/legacy)

@csossi csossi moved this from QA to Ready for Merging in v0.7 Mar 22, 2018
@kevincoleman kevincoleman moved this from Ready for Merging to Production Release in v0.7 May 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
v0.7
Production Release
Development

No branches or pull requests

4 participants