New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.0-RC1 Release #1482
1.0-RC1 Release #1482
Conversation
Both for the in the header, and the AMP__VERSION constant.
Query: https://github.com/Automattic/amp-wp/pulls?utf8=%E2%9C%93&q=is%3Apr+is%3Aclosed+merged%3A2018-09-24T12%3A05%3A49Z..2018-10-03T03%3A17%3A43Z+milestone%3Av1.0+ Attempt to order them by importance, but this is of course subject to review.
amp.php
Outdated
@@ -5,7 +5,7 @@ | |||
* Plugin URI: https://github.com/automattic/amp-wp | |||
* Author: WordPress.com VIP, XWP, Google, and contributors | |||
* Author URI: https://github.com/Automattic/amp-wp/graphs/contributors | |||
* Version: 1.0-beta4 | |||
* Version: 1.0-rc1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's name it 1.0-RC1
following WP conventions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, 17f9eaa changes is to 1.0-RC1
both above and in:
define( 'AMP__VERSION', '1.0-RC1' );
As Weston mentioned, this follows the WordPress convention.
Merged in |
Smoke testing of it looks good so far. |
Add this to the main Compatibility Tool redesign line, as it pertains to this.
This was recently merged, so ensure that it's added.
Here's the amp.zip file, built from this branch |
Smoke Testing Looks Good So Far Hi @westonruter, When you have a chance, could you please review this? Feel free to change the order of PRs in the changelog, of course. Thanks! |
So far, the built amp.zip looks good on the 3 staging sites. |
amp.php
1.0-RC1