Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0-RC1 Release #1482

Merged
merged 10 commits into from Oct 5, 2018
Merged

1.0-RC1 Release #1482

merged 10 commits into from Oct 5, 2018

Conversation

kienstra
Copy link
Contributor

@kienstra kienstra commented Oct 3, 2018

amp.php Outdated
@@ -5,7 +5,7 @@
* Plugin URI: https://github.com/automattic/amp-wp
* Author: WordPress.com VIP, XWP, Google, and contributors
* Author URI: https://github.com/Automattic/amp-wp/graphs/contributors
* Version: 1.0-beta4
* Version: 1.0-rc1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's name it 1.0-RC1 following WP conventions.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, 17f9eaa changes is to 1.0-RC1 both above and in:

define( 'AMP__VERSION', '1.0-RC1' );

@westonruter westonruter changed the title 1.0-rc1 Release 1.0-RC1 Release Oct 3, 2018
As Weston mentioned,
this follows the WordPress convention.
@kienstra
Copy link
Contributor Author

kienstra commented Oct 3, 2018

Merged in 1.0 to allow building and smoke testing from this branch, as this is ideally the last PR of 1.0-RC1

@kienstra
Copy link
Contributor Author

kienstra commented Oct 3, 2018

In preparation for the RC1 release, here's the plugin built from this branch: amp.zip (to build a new file with latest changes)

Smoke testing of it looks good so far.

@kienstra
Copy link
Contributor Author

kienstra commented Oct 4, 2018

Here's the amp.zip file, built from this branch

@kienstra
Copy link
Contributor Author

kienstra commented Oct 4, 2018

Smoke Testing Looks Good So Far

Hi @westonruter,
Smoke testing of the built amp.zip file above on the 3 staging sites has been good so far.

When you have a chance, could you please review this? Feel free to change the order of PRs in the changelog, of course.

Thanks!

@kienstra
Copy link
Contributor Author

kienstra commented Oct 5, 2018

Here's the built amp.zip file from this branch up to the last commit, 03809b9.

@kienstra
Copy link
Contributor Author

kienstra commented Oct 5, 2018

So far, the built amp.zip looks good on the 3 staging sites.

@westonruter westonruter merged commit 6bf2a1d into 1.0 Oct 5, 2018
@westonruter westonruter deleted the release/1.0-rc1 branch October 5, 2018 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants