New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix replace_node_with_children #449

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@Maxime2
Contributor

Maxime2 commented Aug 23, 2016

We need to sanitize children of removed node as if there are more than one those starting from second would be missed in sanitisation in parent's foreach loop.

@mjangda

This comment has been minimized.

Show comment
Hide comment
@mjangda

mjangda Aug 23, 2016

Member

Thanks for the PR. Can you share some example HTML that this fixes?

Member

mjangda commented Aug 23, 2016

Thanks for the PR. Can you share some example HTML that this fixes?

@Maxime2

This comment has been minimized.

Show comment
Hide comment
@Maxime2

Maxime2 Aug 24, 2016

Contributor

Something like that:
<a><span style="color: red;">Red</span>&amp;<span style="color: blue;">Orange</span></a>

Contributor

Maxime2 commented Aug 24, 2016

Something like that:
<a><span style="color: red;">Red</span>&amp;<span style="color: blue;">Orange</span></a>

This was referenced Aug 29, 2016

@mjangda

This comment has been minimized.

Show comment
Hide comment
@mjangda

mjangda Sep 2, 2016

Member

Continued in #462

Member

mjangda commented Sep 2, 2016

Continued in #462

@mjangda mjangda closed this Sep 2, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment