From 64b5a5d0e741950aae0f51f17603b06d8e9a9944 Mon Sep 17 00:00:00 2001 From: Josh Betz Date: Fri, 15 Jun 2012 13:27:21 -0500 Subject: [PATCH] Clean code around `wp_redirect`'s --- vip-dashboard.php | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/vip-dashboard.php b/vip-dashboard.php index 7c340bb..ac4cf6a 100644 --- a/vip-dashboard.php +++ b/vip-dashboard.php @@ -229,7 +229,6 @@ public function add_users_form() { ?> */ public function handle_add_users_form() { global $wpdb; - $redirect = 'admin.php?page=vip_dashboard_users'; if ( !isset($_REQUEST['action']) || 'adduser' != $_REQUEST['action'] ) return; @@ -251,17 +250,18 @@ public function handle_add_users_form() { $errors = $this->create_users($blogids, $emails, $role, $message, $noconfirmation); if ( isset( $errors ) ) { $errors = explode(':', $errors); - $update = $errors[0]; - $people = $errors[1]; - $redirect = add_query_arg( array('update' => $update), $redirect ); - $redirect = add_query_arg( array('users' => $people), $redirect ); + $args = array( + 'update' => $errors[0], + 'people' => $errors[1] + ); } elseif ( $noconfirmation ) { - $redirect = add_query_arg( array('update' => 'addnoconfirmation'), $redirect ); + $args = array( 'update' => 'addnoconfirmation' ); } else { - $redirect = add_query_arg( array('update' => 'newuserconfimation'), $redirect ); + $args = array( 'update' => 'newuserconfimation' ); } } + $redirect = add_query_arg( $args, 'admin.php?page=vip_dashboard_users'); wp_redirect( $redirect ); exit(); } @@ -380,7 +380,7 @@ public function handle_promote_users_form() { $this->promote_users($blogids, $userids, $role); - wp_redirect(add_query_arg('update', $update, $redirect)); + wp_redirect( add_query_arg('update', $update, $redirect) ); exit(); }