New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E-mail Templates options screen: Show first & last name shortcodes #227

Merged
merged 1 commit into from Aug 3, 2018

Conversation

Projects
None yet
2 participants
@naokomc
Contributor

naokomc commented Jul 26, 2018

Show [last_name] and [first_name] in addition to [buyer_full_name] to accomodate for languages with family name -> given name order.

[buyer_full_name] isn't ideal for languages like Japanese, Chinese, Korean, and Vietnamese where the family name is placed in front of the given name.

@mayukojpn pointed out that [last_name] and [first_name] should also work. We tested this and it worked fine.

Why not expose last & first name options on Tickets > Set up > E-mail Templates page?

camptix-e-mail-templates

E-mail Templates options screen: Show first & last name shortcodes
Show `[last_name]` and `[first_name]` in addition to `[buyer_full_name]` to accomodate for languages with family name -> given name order.

@naokomc naokomc added the enhancement label Jul 26, 2018

@coreymckrill coreymckrill merged commit 07dad2d into Automattic:master Aug 3, 2018

@coreymckrill

This comment has been minimized.

Show comment
Hide comment
@coreymckrill

coreymckrill Aug 3, 2018

Contributor

Thanks @naokomc!

Contributor

coreymckrill commented Aug 3, 2018

Thanks @naokomc!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment