Fix error reporting and Theme Test Drive activation #38

Merged
merged 1 commit into from Mar 7, 2013

Conversation

Projects
None yet
2 participants
@SergeyBiryukov
Contributor

SergeyBiryukov commented Mar 7, 2013

There's an error when installing Theme Test Drive:

<br />
<b>Warning</b>:  Illegal offset type in isset or empty in <b>wp-includes/class-wp-error.php</b> on line <b>117</b><br />
ERROR: Failed to activate plugin: 

This is caused by passing the WP_Error object itself as the error code:
http://plugins.trac.wordpress.org/browser/developer/tags/1.1.2/developer.php#L364

Once I replaced that with $activate_result->get_error_message(), I got the proper message:

ERROR: Failed to activate plugin: Plugin file does not exist.

The plugin looks for theme-test-drive/theme-test-drive.php file, which doesn't exist. The correct file is theme-test-drive/themedrive.php.

SergeyBiryukov/developer@7500257 fixes both of these issues.

Fix error reporting
* Fix error reporting when installing and activating plugins
* Fix Theme Test Drive filename

Viper007Bond added a commit that referenced this pull request Mar 7, 2013

Merge pull request #38 from SergeyBiryukov/master
Fix error reporting and Theme Test Drive activation

@Viper007Bond Viper007Bond merged commit 8f20737 into Automattic:master Mar 7, 2013

@Viper007Bond

This comment has been minimized.

Show comment Hide comment
@Viper007Bond

Viper007Bond Mar 7, 2013

Owner

Thanks. 👍

Owner

Viper007Bond commented Mar 7, 2013

Thanks. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment