Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Test fail: `server send callback should execute in multipart packet` #87

Closed
cadorn opened this Issue · 2 comments

3 participants

@cadorn

The server send callback should execute in multipart packet test fails about 20% of the time for me.

I think it is too sensitive.

1) server send callback should execute in multipart packet:
 Error: expected 1 to equal 2
  at Assertion.assert (/pinf/workspaces/github.com/c9/smith.io/node_modules/engine.io/node_modules/expect.js/expect.js:99:13)
  at Assertion.equal (/pinf/workspaces/github.com/c9/smith.io/node_modules/engine.io/node_modules/expect.js/expect.js:200:10)
  at Assertion.be (/pinf/workspaces/github.com/c9/smith.io/node_modules/engine.io/node_modules/expect.js/expect.js:73:24)
  at Object._onTimeout (/pinf/workspaces/github.com/c9/smith.io/node_modules/engine.io/test/server.js:815:26)
@rauchg
Owner

Yeah, we need to figure out the way of making it not rely on time but events.

@afshinm

Correct. I think we should rewrite this test again.
Actually I rely on timeout(s) because I didn't find correct events to write test better.

@rauchg rauchg closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.