Fix isRegExp bug in some edge cases #35

Merged
merged 1 commit into from Oct 19, 2012

Conversation

Projects
None yet
3 participants
Contributor

satazor commented Oct 19, 2012

var s = '' + re; // This fails for the object types mentioned bellow

[object XMLHttpRequestExceptionPrototype]
[object DOMExceptionPrototype]
[object DOMTokenListPrototype]
[object RangePrototype]
[object HTMLAnchorElementPrototype]
[object RangeExceptionPrototype]
[object XPathExceptionPrototype]
[object EventExceptionPrototype]
[object WebKitCSSMatrixPrototype]
[object SVGExceptionPrototype]
[object XMLHttpRequestExceptionPrototype]
[object DOMExceptionPrototype]
[object DOMTokenListPrototype]
[object RangePrototype]
[object HTMLAnchorElementPrototype]
[object RangeExceptionPrototype]
[object XPathExceptionPrototype]
[object EventExceptionPrototype]
[object WebKitCSSMatrixPrototype]
[object SVGExceptionPrototype]
Contributor

satazor commented Oct 19, 2012

Contributor

rauchg commented Oct 19, 2012

That eql thing sux.

@rauchg rauchg added a commit that referenced this pull request Oct 19, 2012

@rauchg rauchg Merge pull request #35 from satazor/master
Fix isRegExp bug in some edge cases
0a6dae8

@rauchg rauchg merged commit 0a6dae8 into Automattic:master Oct 19, 2012

Contributor

satazor commented Oct 19, 2012

Thanks @guille !

Contributor

rauchg commented Oct 19, 2012

Like, it depends on JSON.

Contributor

rauchg commented Oct 19, 2012

hahahah

Contributor

satazor commented Oct 19, 2012

@guille can you bump the package version in npm?

Contributor

rauchg commented Oct 19, 2012

0.2.0 out, thanks a lot @satazor

0.2.0 / 2012-10-19
==================

  * fix isRegExp bug in some edge cases
  * add closure to all assertion messages deferring costly inspects
    until there is actually a failure
  * fix `make test` for recent mochas
  * add inspect() case for DOM elements
  * relax failure msg null check
  * add explicit failure through `expect().fail()`
  * clarified all `empty` functionality in README example
  * added docs for throwException fn/regexp signatures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment