This repository has been archived by the owner on Apr 17, 2023. It is now read-only.
Refactor to use transform string #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Encoding detection/conversion is now being supported from v1.5.0 of Instant Article SDK by transformString function. We can get rid of 'loadHTML' stuffs from our plugin and make the code simpler. This commit also removes the relative url transformation introduced by the comit da90925 (PR #220) but we now should not need this logic on plugin side.
|
LGTM Next version. |
|
Any chance this gets in the 3.2 milestone? |
LiviuJianu
approved these changes
Sep 15, 2016
philipjohn
approved these changes
Oct 5, 2016
demoive
added a commit
that referenced
this pull request
Oct 6, 2016
|
@philipjohn I didn't intend to merge this myself. I simply wanted to resolve the merge conflict, but since it was originally committed straight into master, this was the result. Hope this is ok! |
|
Thanks @yssk22 san @philipjohn some of the merged changes of this PR were reverted with 49c22d0 commit. Could you please re-merge it? It prevents |
sakatam
added a commit
to sakatam/facebook-instant-articles-wp
that referenced
this pull request
Feb 24, 2017
- as @yssk22 commented in Automattic#428, the refactored code has been reverted back by mistake, and it result in garbled MB characters in title.
|
@yssk22 thank you for figuring out! I created a quick PR for this and it'll hopefully be included in the next release. |
sakatam
added a commit
to sakatam/facebook-instant-articles-wp
that referenced
this pull request
Mar 21, 2017
- as @yssk22 commented in Automattic#428, the refactored code has been reverted back by mistake, and it result in garbled MB characters in title.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
transformStringand remove the complexities ofloadHTMLthings.Follows #395
Relates to #369, #344
Fixes #339