New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alternative stats icons #291

Merged
merged 3 commits into from Jun 27, 2018

Conversation

Projects
None yet
2 participants
@porada
Member

porada commented Jun 25, 2018

At the Studio, we use Gridicons when designing the WordPress.com landing pages.

Some of our pages repeatedly mention growth or an increase of something over time. stats and stats-alt often accompany those sections, but I don’t think they cut it. I’d like to propose two alternative states for those two icons to provide some more flexibility and to help us visualize the copy a little better.

Here’s the zoomed-in preview. The new icons are largely based on the originals.

Icon preview

Please me know what you think. ✌️

@porada porada added the icon request label Jun 25, 2018

@porada

This comment has been minimized.

Member

porada commented Jun 25, 2018

BTW, I’m not too happy about the naming convention for these alternatives, but I don’t have a better idea that wouldn’t renaming the originals either. If you think they should be renamed, let me know.

@drw158

This comment has been minimized.

Member

drw158 commented Jun 25, 2018

Thanks @porada, I don't see any reason not to add these in. I think the naming is fine too.

Let someone know if you'd like to add these in yourself, or if you need some help.

@porada

This comment has been minimized.

Member

porada commented Jun 26, 2018

@drw158, if you could review the commit I added and then merge, that would be great. Thanks. 🙂

@porada porada merged commit 433ff08 into master Jun 27, 2018

@porada

This comment has been minimized.

Member

porada commented Jun 27, 2018

I went ahead and merged it! 🖖

@porada porada deleted the add/stats-alternatives branch Jun 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment