Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings Page: calls to protected function in WP Core #1117

Closed
jeherve opened this Issue Sep 15, 2014 · 15 comments

Comments

Projects
None yet
5 participants
@jeherve
Copy link
Member

jeherve commented Sep 15, 2014

In r28493-core, function display_tablenav was changed to protected function display_tablenav. That causes Fatal errors on the settings page, since we use that function in Jetpack:

Fatal error: Call to protected method WP_List_Table::display_tablenav() from context 'Jetpack_Settings_Page' in /wp-content/plugins/jetpack/_inc/lib/admin-pages/class.jetpack-settings-page.php on line 32

screen shot 2014-09-15 at 1 59 42 pm

Reported in #2071481-org and 1939095-t

@georgestephanis

This comment has been minimized.

Copy link
Member

georgestephanis commented Sep 15, 2014

That was committed four months ago? How have we not seen it until now?

@jeherve

This comment has been minimized.

Copy link
Member Author

jeherve commented Sep 15, 2014

I can't reproduce on any of my sites, to be honest. It's most likely only happening with a specific version of PHP.

@gucu

This comment has been minimized.

Copy link

gucu commented Sep 17, 2014

Hi

I'm currently using PHP 5.2 but will try updating to 5.3 to see what happens. I'll let you know.

The error is happening under 5.2.

Rich

@gucu

This comment has been minimized.

Copy link

gucu commented Sep 17, 2014

Hi

I updated to 5.5 and the error message is gone. Hope that helps.

Rich

@georgestephanis

This comment has been minimized.

Copy link
Member

georgestephanis commented Sep 17, 2014

@jeherve You have some 5.2 sites, right? Can you check against those to confirm if you're seeing this?

@jeherve

This comment has been minimized.

Copy link
Member Author

jeherve commented Sep 17, 2014

No luck. I can't reproduce with any of my test sites running 5.2 or 5.4.

@dliebert

This comment has been minimized.

Copy link

dliebert commented Sep 17, 2014

I dentical problem.

Fatal error: Call to protected method WP_List_Table::display_tablenav() from context 'Jetpack_Settings_Page' in /usr/local/share/wordpress/content/plugins/jetpack/_inc/lib/admin-pages/class.jetpack-settings-page.php on line 32

this is on Wordpress 4.0
Jetpack 3.1.1

@jeherve

This comment has been minimized.

Copy link
Member Author

jeherve commented Sep 17, 2014

@dliebert Could you give us more details about your setup? What version of PHP do you use?

@dliebert

This comment has been minimized.

Copy link

dliebert commented Sep 18, 2014

It's a LAMP turnkey linux wordpress box. I havent been able to verify the version. I know its 5 something

@jeherve

This comment has been minimized.

Copy link
Member Author

jeherve commented Sep 18, 2014

Could you create a phpinfo file on your site to find out more about your setup? You cab follow the instructions here to do so:
http://v1.jontangerine.com/silo/php/phpinfo/

@dliebert

This comment has been minimized.

Copy link

dliebert commented Sep 18, 2014

yeah. this wp is local lan only. we have it running in developer mode when this error comes up

@dliebert

This comment has been minimized.

Copy link

dliebert commented Sep 22, 2014

PHP Version
5.2.4-2ubuntu5.23

Linux wordpress 2.6.24-31-generic #1 SMP Tue Feb
14 13:24:00 UTC 2012 i686
Build Date
Feb 11 2012 01:41:39

@dliebert

This comment has been minimized.

Copy link

dliebert commented Sep 22, 2014

When I disable developer mode I get this:
capture

@LUTU-

This comment has been minimized.

Copy link

LUTU- commented Sep 24, 2014

Delete 32 rows of class.jetpack-settings-page.php

List of settings is only all out , no influence

@jeherve

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.