New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable some Modules Network-wide in Multisite #247

Closed
mrjarbenne opened this Issue Feb 22, 2014 · 15 comments

Comments

Projects
None yet
6 participants
@mrjarbenne

mrjarbenne commented Feb 22, 2014

Functionality like WP-Connect (as an example), in institutions that use alternative forms of authentication, disable the ability to properly control who has access to the network. In multisite instances, it makes sense to be able to disable some modules from being activated across the network.

@georgestephanis

This comment has been minimized.

Show comment
Hide comment
@georgestephanis

georgestephanis Feb 22, 2014

Member

Code-wise, that's easily feasible via hooking into the jetpack_get_available_modules filter.

For multisite enhancements, we're looking into adding that for the 3.0 release.

Member

georgestephanis commented Feb 22, 2014

Code-wise, that's easily feasible via hooking into the jetpack_get_available_modules filter.

For multisite enhancements, we're looking into adding that for the 3.0 release.

@mrjarbenne

This comment has been minimized.

Show comment
Hide comment
@mrjarbenne

mrjarbenne Feb 22, 2014

Thanks George. Is there a roadmap of the proposed functionality v3 will make available to multisite networks?

mrjarbenne commented Feb 22, 2014

Thanks George. Is there a roadmap of the proposed functionality v3 will make available to multisite networks?

@jeherve

This comment has been minimized.

Show comment
Hide comment
@jeherve

jeherve Feb 23, 2014

Member

Is there a roadmap of the proposed functionality v3 will make available to multisite networks?

I would recommend installing master on a multisite network of yours, and visiting Jetpack > Sites and Jetpack > Settings in your Network Admin. That will give you a good idea of what's to come, and you can let us know if you find bugs :)

Member

jeherve commented Feb 23, 2014

Is there a roadmap of the proposed functionality v3 will make available to multisite networks?

I would recommend installing master on a multisite network of yours, and visiting Jetpack > Sites and Jetpack > Settings in your Network Admin. That will give you a good idea of what's to come, and you can let us know if you find bugs :)

@mrjarbenne

This comment has been minimized.

Show comment
Hide comment
@mrjarbenne

mrjarbenne Feb 23, 2014

Sounds good. Thanks.
#248

mrjarbenne commented Feb 23, 2014

Sounds good. Thanks.
#248

@mrjarbenne mrjarbenne closed this Feb 23, 2014

@mrjarbenne mrjarbenne reopened this Feb 23, 2014

@jeherve jeherve closed this Feb 24, 2014

@mrjarbenne

This comment has been minimized.

Show comment
Hide comment
@mrjarbenne

mrjarbenne May 21, 2014

With the emergence of version 3.0, I wanted to revisit this enhancement. @georgestephanis inferred something like this might emerge in this version, but I'm not seeing any additions to the Network Admin section that would allow me to block the activation of some of the modules at a network level.

Can this issue be re-opened?

mrjarbenne commented May 21, 2014

With the emergence of version 3.0, I wanted to revisit this enhancement. @georgestephanis inferred something like this might emerge in this version, but I'm not seeing any additions to the Network Admin section that would allow me to block the activation of some of the modules at a network level.

Can this issue be re-opened?

@blobaugh blobaugh reopened this May 21, 2014

@blobaugh blobaugh added this to the 3.1 Freeze milestone May 21, 2014

@blobaugh blobaugh self-assigned this May 21, 2014

@blobaugh

This comment has been minimized.

Show comment
Hide comment
@blobaugh

blobaugh May 21, 2014

Contributor

We may have another issue regarding this somewhere else, but I am reopening and assigning to myself. @georgestephanis and I had discussed some ways to implement this feature which I do agree would be good to have. It was originally part of the roadmap but was kicked down the road due to a couple other big ticket items.

Contributor

blobaugh commented May 21, 2014

We may have another issue regarding this somewhere else, but I am reopening and assigning to myself. @georgestephanis and I had discussed some ways to implement this feature which I do agree would be good to have. It was originally part of the roadmap but was kicked down the road due to a couple other big ticket items.

@mrjarbenne

This comment has been minimized.

Show comment
Hide comment
@mrjarbenne

mrjarbenne May 21, 2014

Thanks Ben. In my particular instance, where WP is being used with Elementary school students; the ability to turn off certain functionality, while still empowering young students to have a blog, would be a huge benefit. Cheers.

mrjarbenne commented May 21, 2014

Thanks Ben. In my particular instance, where WP is being used with Elementary school students; the ability to turn off certain functionality, while still empowering young students to have a blog, would be a huge benefit. Cheers.

@blobaugh

This comment has been minimized.

Show comment
Hide comment
@blobaugh

blobaugh May 21, 2014

Contributor

@mrjarbenne we can make this happen right now. Email me and we can work out the details of what you need through existing filters. blobaugh AT automattic DOT com

Contributor

blobaugh commented May 21, 2014

@mrjarbenne we can make this happen right now. Email me and we can work out the details of what you need through existing filters. blobaugh AT automattic DOT com

@blobaugh

This comment has been minimized.

Show comment
Hide comment
@blobaugh

blobaugh Jul 7, 2014

Contributor

For reference this branch is currently home to the updates https://github.com/automattic/jetpack/tree/multisite

Contributor

blobaugh commented Jul 7, 2014

For reference this branch is currently home to the updates https://github.com/automattic/jetpack/tree/multisite

@blobaugh blobaugh modified the milestones: 3.2, 3.1 Freeze Jul 8, 2014

@blobaugh

This comment has been minimized.

Show comment
Hide comment
@blobaugh

blobaugh Jul 8, 2014

Contributor

Bumping to Jetpack 3.2 milestone as there is still a bug I have not been able to squash

Contributor

blobaugh commented Jul 8, 2014

Bumping to Jetpack 3.2 milestone as there is still a bug I have not been able to squash

@mrjarbenne

This comment has been minimized.

Show comment
Hide comment
@mrjarbenne

mrjarbenne Jul 8, 2014

Thanks for continuing the fight.

mrjarbenne commented Jul 8, 2014

Thanks for continuing the fight.

@georgestephanis

This comment has been minimized.

Show comment
Hide comment
@georgestephanis
Member

georgestephanis commented Jul 8, 2014

solidarity

@blobaugh

This comment has been minimized.

Show comment
Hide comment
@blobaugh

blobaugh Jul 9, 2014

Contributor

@georgestephanis when you have a moment can you take a look at this? The issue I am having is that the selected visible modules work fine however the auto-activated modules list does not seem to work at all.

The filters are at https://github.com/Automattic/jetpack/blob/multisite/class.jetpack-network.php#L82-L88 and when I debug them they do in fact run when I expect them too but are not seeming to get applied.

The connection and activation is at https://github.com/Automattic/jetpack/blob/multisite/class.jetpack-network.php#L430-L558

Contributor

blobaugh commented Jul 9, 2014

@georgestephanis when you have a moment can you take a look at this? The issue I am having is that the selected visible modules work fine however the auto-activated modules list does not seem to work at all.

The filters are at https://github.com/Automattic/jetpack/blob/multisite/class.jetpack-network.php#L82-L88 and when I debug them they do in fact run when I expect them too but are not seeming to get applied.

The connection and activation is at https://github.com/Automattic/jetpack/blob/multisite/class.jetpack-network.php#L430-L558

@blobaugh

This comment has been minimized.

Show comment
Hide comment
@blobaugh

blobaugh Jul 17, 2014

Contributor

Closing this because I like the title of #866 better :)

Contributor

blobaugh commented Jul 17, 2014

Closing this because I like the title of #866 better :)

@blobaugh blobaugh closed this Jul 17, 2014

@blobaugh blobaugh added the duplicate label Jul 17, 2014

@richardmtl

This comment has been minimized.

Show comment
Hide comment
@richardmtl

richardmtl Jul 17, 2014

Member

@blobaugh if you ever need a good Issue title, I'm your man! 😆

Member

richardmtl commented Jul 17, 2014

@blobaugh if you ever need a good Issue title, I'm your man! 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment