New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments: Removes all actions on comment_form_after #7357

Closed
chrisaldrich opened this Issue Jun 17, 2017 · 3 comments

Comments

Projects
None yet
3 participants
@chrisaldrich

chrisaldrich commented Jun 17, 2017

Steps to reproduce the issue

On a self-hosted install (tested with the standard 2016 theme) with the webmention plugin (installed/activated) and JetPack (installed/activated) with the setting "Let readers use WordPress.com, Twitter, Facebook, or Google+ accounts to comment" activated under "Discussions"

What I expected

Underneath the typical comments form I expected to be able to see a short piece of text explaining what a webmention is along with an input box for a permalink URL followed by a "Ping Me" button, pictured below.

pingme

What happened instead

The modified comments box takes over the entire section of that part of the page and doesn't allow it to display anything which hooks in below it.

If I disable the WP/Twitter/FB/G+ account options, then the expected webmention form shows up properly.

There's also a potential CSS bug in that if a user begins entering a long segment of text, the UI "moves" down the page and can eventually disappear making it impossible to click the "Post Comment" button or choose the two "notify me" checkboxes. One would generally expect the form to have its own scroll bar and the post button to stay in place.

Additional information

Like the webmention plugin, another example of a plugin which isn't allowed to be hooked in underneath the traditional comments box is this citation plugin.

Cross reference: pfefferle/wordpress-webmention#143

@kraftbj

This comment has been minimized.

Show comment
Hide comment
@kraftbj

kraftbj Jun 17, 2017

Contributor

That's somewhat intentional.

Webmentions use comment_form_after to hook in after the comment form ( https://github.com/pfefferle/wordpress-webmention/blob/master/webmention.php#L63 ) and, since Jetpack is trying to take over the comment form, we remove everything on that hook ( https://github.com/Automattic/jetpack/blob/master/modules/comments/comments.php#L115 ).

@beaulebens I realize this was eons ago now, but I think you might have the best operational knowledge of that decision when Highlander was built. Is removing all of the actions on the after hook needed? Would hooking very early (priority 0?) and then flush the buffer and injecting the Highlander form work?

Contributor

kraftbj commented Jun 17, 2017

That's somewhat intentional.

Webmentions use comment_form_after to hook in after the comment form ( https://github.com/pfefferle/wordpress-webmention/blob/master/webmention.php#L63 ) and, since Jetpack is trying to take over the comment form, we remove everything on that hook ( https://github.com/Automattic/jetpack/blob/master/modules/comments/comments.php#L115 ).

@beaulebens I realize this was eons ago now, but I think you might have the best operational knowledge of that decision when Highlander was built. Is removing all of the actions on the after hook needed? Would hooking very early (priority 0?) and then flush the buffer and injecting the Highlander form work?

@kraftbj

This comment has been minimized.

Show comment
Hide comment
@kraftbj

kraftbj Jun 17, 2017

Contributor

As an aside, I haven't written this up yet for internal discussion, but I would like us to evaluate the "modern" open web standards that are coming out -- webmentions, websub (formerly PubSubHubbub), jsonfeed, etc -- and see how we/WP.com could play nicely with them. Micro.blog supports these and, in the interest of an open and interchangeable web, I'd like us to keep it all in mind. ( cc: @iandunn )

Contributor

kraftbj commented Jun 17, 2017

As an aside, I haven't written this up yet for internal discussion, but I would like us to evaluate the "modern" open web standards that are coming out -- webmentions, websub (formerly PubSubHubbub), jsonfeed, etc -- and see how we/WP.com could play nicely with them. Micro.blog supports these and, in the interest of an open and interchangeable web, I'd like us to keep it all in mind. ( cc: @iandunn )

@kraftbj kraftbj added the [Type] Bug label Jun 17, 2017

@kraftbj kraftbj changed the title from JetPack social commenting option hijacks other plugins' ability to display to Comments: Removes all actions on comment_form_after Jun 17, 2017

@jeherve

This comment has been minimized.

Show comment
Hide comment
@jeherve

jeherve Sep 7, 2017

Member

👍

Somewhat related: #477

Member

jeherve commented Sep 7, 2017

👍

Somewhat related: #477

@oskosk oskosk closed this in #7358 Dec 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment