Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscriptions: include CPTs #760

Open
jeherve opened this issue Jun 20, 2014 · 68 comments

Comments

@jeherve
Copy link
Member

commented Jun 20, 2014

Currently, the subscriptions module will only notify subscribers when a new post is made on the blog.

Since WP 3.0, CPTs (custom-post-types) have started playing an increasingly dominant role in many blogs. Therefore, I believe it would be a great addition to Jetpack to add the option for blog admins to select which post types will be included in these updates.

Original trac ticket:

@jeherve jeherve added this to the vFuture milestone Jun 20, 2014
@richardmtl

This comment has been minimized.

Copy link
Member

commented Jul 25, 2014

Requested in 1900539-t

@jeherve jeherve modified the milestones: vFuture, 3.2 Aug 1, 2014
@jeherve

This comment has been minimized.

Copy link
Member Author

commented Sep 8, 2014

Also suggested in 2057439-org

@georgestephanis

This comment has been minimized.

Copy link
Member

commented Oct 6, 2014

Considering the varied methods that CPTs can be displayed with custom meta and the like, a general format for sending out subscriptions would likely be inadequate to properly display, and claiming support may provide a disservice.

@georgestephanis georgestephanis removed this from the 3.2 milestone Oct 6, 2014
@mrwweb

This comment has been minimized.

Copy link

commented Oct 6, 2014

Just came to check on the status of this feature and am really bummed to see it bumped from 3.2.

@georgestephanis are you suggesting that the feature won't be added ever?

To play devil's advocate for a moment, all of these same restrictions come from the default custom post type RSS feed support in WordPress core. Granted, there are filters available to add meta data as needed, but I suspect few sites actually do that. I have no idea if it's possible or challenging to add similar filters, presumably targeting the_content conditionally when Jetpack subscriptions are watching.

With that in mind, I hope you'll at least consider adding the feature with a big note about limitations. I admit I could really use it on a project right now, but FWIW, I expected that limitation anyway.

@georgestephanis

This comment has been minimized.

Copy link
Member

commented Oct 6, 2014

I'm certainly not saying never, just that it will need more thought and development time that is available for 3.2 (which I'm probably going to fire off the first beta in the next hour or so).

It may wind up looking something like for CPTs, the content that gets synced to wpcom and sent out to subcribers is filtered, so themers / plugin authors can specify how it's formatted. But then it'd need further development wpcom side to strip out anything potetially malicious.

@jeherve

This comment has been minimized.

Copy link
Member Author

commented Nov 20, 2014

@aheckler

This comment has been minimized.

Copy link
Member

commented Dec 11, 2014

Requested in 2027277-t.

@chaselivingston

This comment has been minimized.

Copy link
Contributor

commented Feb 16, 2015

Requested in 2096887-t

@jeherve

This comment has been minimized.

Copy link
Member Author

commented May 6, 2015

@mikeyarce

This comment has been minimized.

Copy link
Member

commented May 6, 2015

Also suggested here:
2180609-t

@jeherve

This comment has been minimized.

@jeherve

This comment has been minimized.

@jeherve

This comment has been minimized.

@jeherve

This comment has been minimized.

Copy link
Member Author

commented Aug 1, 2015

Also suggested here: 2091078-t

@kraftbj kraftbj added this to the vFuture milestone Aug 3, 2015
@richardmtl

This comment has been minimized.

Copy link
Member

commented Aug 4, 2015

requested in 2282088-t

@richardmtl

This comment has been minimized.

Copy link
Member

commented Aug 17, 2015

requested in 2305017-t

@samhotchkiss samhotchkiss modified the milestones: vFuture, Needs Triage Aug 29, 2015
@pmciano

This comment has been minimized.

Copy link

commented Jan 24, 2017

3019681-t

@csonnek

This comment has been minimized.

Copy link
Member

commented Mar 1, 2017

Requested in 3086327-t

@lamdayap

This comment has been minimized.

Copy link

commented Apr 4, 2017

requested 3143224-t

@codestor4

This comment has been minimized.

Copy link
Contributor

commented May 10, 2017

requested 3202917-t

@annezazu

This comment has been minimized.

Copy link

commented Jun 15, 2017

3252447-t

@annezazu

This comment has been minimized.

Copy link

commented Jun 19, 2017

Would be really neat to put this in place for WPJM cc @jom and @davoraltman

@NujabesSoul

This comment has been minimized.

Copy link

commented Sep 25, 2017

Requested 697933-zen

@seejacobscott

This comment has been minimized.

Copy link

commented Oct 28, 2017

requested in 754461-zen

@richardmtl

This comment has been minimized.

Copy link
Member

commented Feb 1, 2018

921071-zen

@ntpixels

This comment has been minimized.

Copy link

commented Feb 14, 2018

938726-zen

@ntpixels

This comment has been minimized.

Copy link

commented Apr 16, 2018

1094364-zen

@rvpatel

This comment has been minimized.

Copy link

commented Apr 19, 2018

https://wordpress.org/support/topic/how-to-manage-notify-me-of-follow-up-comments-by-email-for-custom-post-type/
@erania-pinnera and @tmmbecker

Please provide a options for post type selection where you have need Notify me of follow-up comments by email

\jetpack\modules\subscriptions.php line no 616
if ( FALSE === has_filter( 'comment_form', 'show_subscription_checkbox' ) && 1 == get_option( 'stc_enabled', 1 ) && empty( $post->post_password ) && 'post' == get_post_type() ) {

There have not any filter function for change the code. Can we apply on custom post type?

@jeherve

This comment has been minimized.

Copy link
Member Author

commented Apr 19, 2018

There have not any filter function for change the code. Can we apply on custom post type?

Adding a filter here or changing the code in the plugin won't help I'm afraid. We would need to add support for Custom Post Types on WordPress.com first, where the emails are generated and sent.

We will update this issue once we make progress on this.

@coder-karen

This comment has been minimized.

Copy link

commented Sep 3, 2018

Requested in 1388180-zen

@pmciano

This comment has been minimized.

Copy link

commented Dec 31, 2018

Requested in 1677630-zen

@mfigrs

This comment has been minimized.

Copy link

commented Feb 4, 2019

After 4.5 years since the original issue, it is quite disappointing that Jetpack still can't send notification on CPTs - not even a post title and link.

Is there a way to make a CPT pretend to be a regular post for Jetpack?

@jeherve

This comment has been minimized.

Copy link
Member Author

commented Feb 4, 2019

Is there a way to make a CPT pretend to be a regular post for Jetpack?

I am afraid not, that is not really possible right now. Since the posts are sent from the WordPress.com servers, you can't really "trick" the posts to send out emails.

We'll post on this issue as soon as we start working on Subscriptions again and can pick this up.

@rockstarwebdesign

This comment has been minimized.

Copy link

commented Feb 4, 2019

And that is? Maybe for the year 2030? :(

@jeherve

This comment has been minimized.

Copy link
Member Author

commented Feb 4, 2019

And that is? Maybe for the year 2030? :(

We don't have any estimate as this is not on our roadmap right now. We'll post here when that changes.

@mzakariya

This comment has been minimized.

Copy link

commented Mar 26, 2019

Requested in 1905752-zen.

@stale

This comment has been minimized.

Copy link

commented Sep 22, 2019

This issue has been marked as stale. This happened because:

  • It has been inactive in the past 6 months.
  • It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

@stale stale bot added the [Status] Stale label Sep 22, 2019
@tmmbecker

This comment has been minimized.

Copy link

commented Sep 23, 2019

Still a request.

@rockstarwebdesign

This comment has been minimized.

Copy link

commented Sep 23, 2019

Yes, still a request, after all these years. Would be nice to know it has been addressed : (

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
You can’t perform that action at this time.