Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gallery Widget: migrate to new Core Gallery Widget #7830

Closed
jeherve opened this issue Sep 21, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@jeherve
Copy link
Member

commented Sep 21, 2017

WordPress Core is looking into adding a new Gallery Widget in WP 4.9:
https://core.trac.wordpress.org/ticket/41914

It would be nice if we could migrate our own Gallery Widget over, while keeping its options.

@westonruter

This comment has been minimized.

Copy link
Contributor

commented Sep 25, 2017

The core gallery widget has landed in trunk (4.9-alpha). See r41590.

The Tiled Galleries module and slideshows in Jetpack should work properly with core's Gallery widget, but this is reported to not be working right:

For example, with Jetpack enabled, users can choose between a thumbnail and a slideshow gallery, but the slideshow option doesn’t seem to work correctly in the widget.

Dev note: https://make.wordpress.org/core/2017/09/25/introducing-the-gallery-widget/

@jeherve jeherve added [Pri] BLOCKER and removed [Pri] High labels Oct 16, 2017

@jeherve jeherve added this to the 5.5 milestone Oct 16, 2017

@westonruter

This comment has been minimized.

Copy link
Contributor

commented Oct 19, 2017

Core patch has been proposed to improve extensibility of the media widgets: https://core.trac.wordpress.org/ticket/42285

With that patch committed, all Jetpack would have to do is:

add_filter( 'widget_media_gallery_instance_schema', function( $schema ) {
	$schema['type'] = array(
		'type' => 'string',
		'enum' => array( 'default', 'rectangular', 'square', 'circle', 'columns' ),
		'description' => __( 'Type of gallery.', 'jetpack' ),
		'default' => 'default',
	);
	return $schema;
} );

Please test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.