Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing Buttons: Email sharing message not translating correctly. #7880

Open
seejacobscott opened this issue Sep 27, 2017 · 10 comments

Comments

@seejacobscott
Copy link

commented Sep 27, 2017

When a site is using a different language using the Email sharing button is still sending the message in English.

Taking a look the string itself should be translated. The reporting used does have their site in French.

Checking the code here, it indicates the translation string should work as expected:

$content = sprintf( __( '%1$s (%2$s) thinks you may be interested in the following post:', 'jetpack' ), $data['name'], $data['source'] );

The translated string can be seen here: https://translate.wordpress.org/projects/wp-plugins/jetpack/stable/fr/default?filters%5Bterm%5D=be+interested&filters%5Buser_login%5D=&filters%5Bstatus%5D=current_or_waiting_or_fuzzy_or_untranslated&filter=Filter&sort%5Bby%5D=priority&sort%5Bhow%5D=desc

User reported in 3318004-t that they're site is set to use the French language, but sharing is sending out the following:

image

@danjjohnson was able to confirm this by testing on his own site in French:

Confirmed. My site is in French, but the email came through in English, and the success message was also English:
image

@tmmbecker

This comment has been minimized.

Copy link

commented Oct 10, 2017

User has inquired about the status of this in 725600-zen

@pierrefrance

This comment has been minimized.

Copy link

commented Nov 13, 2017

I see this has been set as a low priority, and still not fixed in the latest release. Unfortunately, it's a bigger priority than this for every media not in english as main language, it really sends an unprofessional message.

@cena

This comment has been minimized.

Copy link

commented Jan 5, 2018

Any movement on this? 882780-zen

@pierrefrance

This comment has been minimized.

Copy link

commented Feb 13, 2018

Lots of Jetpack versions afterwards and still no movement on this issue.

@pierrefrance

This comment has been minimized.

Copy link

commented Mar 14, 2018

Is there a way to correct this issue ?

@jeherve

This comment has been minimized.

Copy link
Member

commented Mar 14, 2018

@pierrefrance Unfortunately not, but we'll update this issue once we find a way to fix this.

@pierrefrance

This comment has been minimized.

Copy link

commented Jun 21, 2018

Other part are not translated, for example comment subscription :

6632536768512000

@jeherve

This comment has been minimized.

Copy link
Member

commented Sep 4, 2018

@pierrefrance This text is translated if your site is set to French and if you have downloaded the French language pack for Jetpack. This can be done by going to Tableau de Bord > Mises à jour.

123a4bd3329fa98c4b197073310d770e _screenshot 2018-09-04 at 12 27 29

screenshot 2018-09-04 at 12 25 01

@pierrefrance

This comment has been minimized.

Copy link

commented Sep 4, 2018

Confirmed ! Thank you so much (at last).

Now we need an editor for all these transactionnal e-mails. :-) For exemple, we'd like to add teasers and call to subscribe, discounts, etc.

@stale

This comment has been minimized.

Copy link

commented Mar 3, 2019

This issue has been marked as stale. This happened because:

  • It has been inactive in the past 6 months.
  • It hasn’t been labeled `[Pri] Blocker`, `[Pri] High`.

No further action is needed. But it's worth checking if this ticket has clear reproduction steps and it is still reproducible. Feel free to close this issue if you think it's not valid anymore — if you do, please add a brief explanation.

@stale stale bot added the [Status] Stale label Mar 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.