Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carousel: Javascript error in IE10 #791

Closed
jeherve opened this issue Jul 4, 2014 · 1 comment
Closed

Carousel: Javascript error in IE10 #791

jeherve opened this issue Jul 4, 2014 · 1 comment
Labels
[Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Status] Invalid [Type] Bug When a feature is broken and / or not performing as intended

Comments

@jeherve
Copy link
Member

jeherve commented Jul 4, 2014

Carousel View does not open in IE10: instead, the attachment pas is opened.
When checking the Javascript console, you get the following error:

SCRIPT1028: Expected identifier, string or number
jetpack-carousel.js, line 185, char 5

Could the problem be related to this bug?
http://stackoverflow.com/questions/12675622/script1028-expected-identifier-string-or-number

Reported here:
http://wordpress.org/support/topic/carousel-not-working-with-ie-10?replies=1

Original trac ticket: https://plugins.trac.wordpress.org/ticket/2071
@samhotchkiss samhotchkiss modified the milestone: Needs Triage Aug 28, 2015
@jeherve
Copy link
Member Author

jeherve commented Feb 15, 2016

Closing, as I can't seem to reproduce anymore.

@jeherve jeherve closed this as completed Feb 15, 2016
@jeherve jeherve modified the milestone: Needs Triage Feb 15, 2016
leogermani pushed a commit that referenced this issue Aug 12, 2022
@donnchawp
Move the text of the settings pages into separate files. (#791)
f4e0002
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Carousel A fullscreen modal appearing when clicking on an image in a gallery or tiled gallery. [Status] Invalid [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jeherve @samhotchkiss