Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Refactor all register_activation_hook() calls in modules #882

Closed
blobaugh opened this Issue · 2 comments

4 participants

@blobaugh

There is at least one register_activation_hook() call within a module. These need to be refactored to use jetpack_activate_module_$module as the register_activation_hook() call will never happen as only that call in the main plugin file is ever triggered.

@blobaugh blobaugh referenced this issue from a commit
@michaeldcain michaeldcain Add Custom Content Type
Add module for Custom Content Types and Portfolio CPT
cd02c0f
@blobaugh blobaugh added this to the 3.2 milestone
@jeherve jeherve added the General label
@scotchfield

Hi there, and thanks for the Good First Bug label! I took a crack at this.
I only saw one call to register_activation_hook in the modules. Submitting a pull request. Please be gentle!

@georgestephanis georgestephanis referenced this issue from a commit
@georgestephanis georgestephanis Use an action, not plugin activation hook.
But leave the plugin activation hook there for legacy reasons.

Props @scotchfield
Fixes #904, #882
e00da92
@enejb
Owner

@georgestephanis closing this issue.
Feel free to open it if I missed something.

@enejb enejb closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.