Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Refactor all register_activation_hook() calls in modules #882

Closed
blobaugh opened this Issue Jul 23, 2014 · 2 comments

Comments

Projects
None yet
4 participants
Contributor

blobaugh commented Jul 23, 2014

There is at least one register_activation_hook() call within a module. These need to be refactored to use jetpack_activate_module_$module as the register_activation_hook() call will never happen as only that call in the main plugin file is ever triggered.

@blobaugh blobaugh referenced this issue Jul 23, 2014

@michaeldcain michaeldcain Add Custom Content Type
Add module for Custom Content Types and Portfolio CPT
cd02c0f

@blobaugh blobaugh added this to the 3.2 milestone Jul 23, 2014

@jeherve jeherve added the General label Jul 23, 2014

Contributor

scotchfield commented Jul 29, 2014

Hi there, and thanks for the Good First Bug label! I took a crack at this.
I only saw one call to register_activation_hook in the modules. Submitting a pull request. Please be gentle!

@georgestephanis georgestephanis added a commit that referenced this issue Jul 31, 2014

@georgestephanis georgestephanis Use an action, not plugin activation hook.
But leave the plugin activation hook there for legacy reasons.

Props @scotchfield
Fixes #904, #882
e00da92
Member

enejb commented Sep 11, 2014

@georgestephanis closing this issue.
Feel free to open it if I missed something.

@enejb enejb closed this Sep 11, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment