Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: Using visibility with widget causes filters to not load #8840

Closed
ebinnion opened this issue Feb 14, 2018 · 3 comments
Closed

Search: Using visibility with widget causes filters to not load #8840

ebinnion opened this issue Feb 14, 2018 · 3 comments
Labels
[Feature] Search For all things related to Search [Type] Bug When a feature is broken and / or not performing as intended

Comments

@ebinnion
Copy link
Contributor

While testing on the Independent Publisher theme, I noticed that when I set the search widget to only show on the blog page or the search page, that the filters don't get loaded. 馃槥

To reproduce:

  • Ensure you have a Jetpack site with a professional plan
  • I imagine it's the same issue for other themes, but perhaps start with the theme above
  • Add search widget with filters. Make sure visibility options are not set
  • Perform a search on the frontend and ensure filters are returned
  • Add visibility options
  • Observe that filters don't show

I noticed that when visibility is set, and the filters don't show, that we didn't add aggregations to the search query. So, I'd assume that the issue is in how we load the aggregations from the widget option.

@ebinnion ebinnion added [Type] Bug When a feature is broken and / or not performing as intended [Feature] Search For all things related to Search labels Feb 14, 2018
@ebinnion ebinnion added this to the 5.9 milestone Feb 14, 2018
@jeherve jeherve modified the milestones: 5.9, 6.0 Mar 7, 2018
@zinigor zinigor modified the milestones: 6.0, 6.1 Mar 28, 2018
@ntpixels
Copy link

ntpixels commented Apr 9, 2018

Also reported in 1076711-zen
theme: customized Genesis theme

@jeherve jeherve removed this from the 6.1 milestone May 2, 2018
@eliorivero
Copy link
Contributor

I verified that this setup for visibility works fine to allow the widget and its filters to be displayed in, for example, a posts page and the search results.

captura de pantalla 2018-08-31 a la s 17 04 23

This is the expected behavior of visibility so I'll close this for now.

@ebinnion
Copy link
Contributor Author

Thanks for testing and closing @eliorivero. It's been quite a while since I reported, but I imagine that I was probably doing something like setting "page is posts page" by itself. Now I understand that "page is search results" also needs to be set.

I've tested again and it seems to work as expected. 馃憤

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Search For all things related to Search [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

No branches or pull requests

5 participants