Skip to content

Custom Content Types: sharing buttons displayed in shortcode #886

Open
jeherve opened this Issue Jul 23, 2014 · 9 comments

9 participants

@jeherve
Automattic member
jeherve commented Jul 23, 2014

Steps to reproduce:

  1. Activate the module
  2. Go to Settings > Writing and enable the Portfolio post type
  3. Create a new project within the Portfolio post type, and publish it
  4. In one of your pages, add the [portfolio] shortcode
  5. In Settings > Sharing, enable sharing buttons for Projects
  6. Notice as the sharing buttons appear under each project listed with the shortcode.
@jeherve jeherve added this to the 3.1 Freeze milestone Jul 23, 2014
@lancewillett
Automattic member

What's the expected behavior?

@jeherve
Automattic member
jeherve commented Jul 24, 2014

I would expect the sharing buttons not to be displayed under each project listed with the shortcode. When selecting "Projects" under Settings > Sharing, I expect the buttons to appear at the bottom of each project page only.

I feel the problem is similar to what happened a few months ago with Twenty Fourteen's Ephemera widget: the sharing buttons were displayed there as well (see #1715400-org for the initial report). We fixed it in 341f00f.

@lancewillett
Automattic member

Would there be a use case you could imagine where an author does want to show sharing buttons under each project in the index/grid view?

@jeherve
Automattic member
jeherve commented Jul 25, 2014

Yes, I'm guessing that's what a user would expect when selecting "Front Page, Archive Pages, and Search Results " in the Sharing settings:

screen shot 2014-07-25 at 10 41 13 pm

@lancewillett
Automattic member

OK! I understand better now. Thanks Jeremy.

@blobaugh blobaugh modified the milestone: 3.1 Freeze, 3.2 Aug 11, 2014
@georgestephanis georgestephanis modified the milestone: 3.3, 3.2 Oct 1, 2014
@enejb
Automattic member
enejb commented Dec 6, 2014

This also applies to likes.

@lezama lezama modified the milestone: 3.3, 3.4 Dec 16, 2014
@jeherve jeherve modified the milestone: 3.4, 3.5 Jan 28, 2015
@jeherve
Automattic member
jeherve commented May 28, 2015

Related issue here:
https://wordpress.org/support/topic/share-buttons-disappear-from-page-when-i-add-plugin-shortcode?replies=1&view=all

Jetpack's sharing buttons disappear whenever you add another loop in the post via a shortcode.

@dereksmart dereksmart modified the milestone: 3.6, 3.7 Jun 25, 2015
@samhotchkiss samhotchkiss modified the milestone: 3.7, Needs Triage Aug 28, 2015
@zinigor zinigor modified the milestone: 3.9, Needs Triage Dec 1, 2015
@jeherve jeherve modified the milestone: 4.0, 3.9 Jan 15, 2016
@jeherve jeherve modified the milestone: 4.1, 4.3 Jun 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.