Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Updates to the Custom Post Type setting found on Writing admin page. #891

Closed
enejb opened this Issue · 6 comments

5 participants

@enejb
Owner
  • We should move the display numbers to the readings page.
  • Make sure if the theme added support via add_theme_support that we don't have a checkbox. See https://cloudup.com/i4w9WfOx70K
@enejb enejb added the Theme Tools label
@georgestephanis
@kraftbj
Owner
@michaeldcain

We tried the checked but disabled approach early on, but thought that users might like to turn the CPT off, even in a Portfolio-supported theme. I think the point of making it a user-set option was to let them make the decision.

@enejb
Owner

Now that I think of it. Do we even need that checkbox? Don't we have a feature box that you activate in the Jetpack admin?

@jeherve
Owner

I assume the checkbox is only there because there will eventually be more content types, and you'll be able to activate the Custom Content Types module in Jetpack > Settings, and then only activate the Custom Post Types you're interested in in Settings > Writing.

@michaeldcain

I assume the checkbox is only there because there will eventually be more content types, and you'll be able to activate the Custom Content Types module in Jetpack > Settings, and then only activate the Custom Post Types you're interested in in Settings > Writing.

Exactly.

@enejb enejb closed this issue from a commit
@enejb enejb Custom Post Type: fixes #891
Split the custom post type to settings to 2 pages, reading and writing.
6ae2e2b
@enejb enejb closed this in 6ae2e2b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.