Updates to the Custom Post Type setting found on Writing admin page. #891

Closed
enejb opened this Issue Jul 23, 2014 · 6 comments

Projects

None yet

5 participants

@enejb
Member
enejb commented Jul 23, 2014
  • We should move the display numbers to the readings page.
  • Make sure if the theme added support via add_theme_support that we don't have a checkbox.
    See https://cloudup.com/i4w9WfOx70K
@enejb enejb added the Theme Tools label Jul 23, 2014
@georgestephanis
Member

Or perhaps have the check box, but have it checked and disabled?

@kraftbj
Contributor
kraftbj commented Jul 24, 2014

I like the disabled checkbox, but with a note that it is enabled by the
theme. I think IS does this type of notice when footer widgets are enabled.
On Jul 23, 2014 6:13 PM, "George Stephanis" notifications@github.com
wrote:

Or perhaps have the check box, but have it checked and disabled?


Reply to this email directly or view it on GitHub
#891 (comment).

@michaeldcain
Member

We tried the checked but disabled approach early on, but thought that users might like to turn the CPT off, even in a Portfolio-supported theme. I think the point of making it a user-set option was to let them make the decision.

@enejb
Member
enejb commented Jul 24, 2014

Now that I think of it. Do we even need that checkbox? Don't we have a feature box that you activate in the Jetpack admin?

@jeherve
Member
jeherve commented Jul 24, 2014

I assume the checkbox is only there because there will eventually be more content types, and you'll be able to activate the Custom Content Types module in Jetpack > Settings, and then only activate the Custom Post Types you're interested in in Settings > Writing.

@michaeldcain
Member

I assume the checkbox is only there because there will eventually be more content types, and you'll be able to activate the Custom Content Types module in Jetpack > Settings, and then only activate the Custom Post Types you're interested in in Settings > Writing.

Exactly.

@enejb enejb added a commit that closed this issue Jul 24, 2014
@enejb enejb Custom Post Type: fixes #891
Split the custom post type to settings to 2 pages, reading and writing.
6ae2e2b
@enejb enejb closed this in 6ae2e2b Jul 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment