Skip to content

Settings - Traffic: add setting for Shortlinks - #12093

Merged
eliorivero merged 2 commits into
masterfrom
add/settings-shortlinks
Apr 22, 2019
Merged

Settings - Traffic: add setting for Shortlinks#12093
eliorivero merged 2 commits into
masterfrom
add/settings-shortlinks

Conversation

@eliorivero

@eliorivero eliorivero commented Apr 18, 2019

Copy link
Copy Markdown
Contributor

Fixes #11935

Changes proposed in this Pull Request:

  • add a toggle for Shortlinks in the Traffic tab
  • make the setting searchable
  • remove searchable module
  • don't activate Shortlinks by default

Testing instructions:

  • Go to Jetpack settings, Traffic tab. Ensure the toggle is there, above Sitemaps
  • if Jetpack is in Development mode, the toggle must be disabled

Captura de Pantalla 2019-04-18 a la(s) 18 52 17

  • Verify it works as expected

Proposed changelog entry for your changes:

@eliorivero eliorivero added Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review This PR is ready for review. Admin Page React-powered dashboard under the Jetpack menu labels Apr 18, 2019
@eliorivero eliorivero added this to the 7.3 milestone Apr 18, 2019
@eliorivero
eliorivero requested a review from a team April 18, 2019 21:56
@eliorivero eliorivero self-assigned this Apr 18, 2019
@jetpackbot

jetpackbot commented Apr 18, 2019 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: May 7, 2019.
Scheduled code freeze: April 30, 2019

Generated by 🚫 dangerJS against 4d12569

jeherve
jeherve previously requested changes Apr 19, 2019
View reviewed changes

@jeherve jeherve left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick note about the module toggle.

Comment thread _inc/client/traffic/shortlinks.jsx Outdated
@jeherve jeherve added [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. and removed [Status] Needs Review This PR is ready for review. labels Apr 19, 2019
@eliorivero
Settings - Traffic: add setting for Shortlinks. Make it searchable, r…
5e8bc6e 
…emove searchable module. Don't activate Shortlinks by default.
@eliorivero
Fix missing isLinked prop. I have replaced it with isSiteConnected be…
4d12569 
…cause this is a site-wide setting that doesn't rely on a user connection like After the Deadline does.
@eliorivero
eliorivero force-pushed the add/settings-shortlinks branch from 9f05320 to 4d12569 Compare April 22, 2019 18:40
@eliorivero eliorivero added [Status] Needs Review This PR is ready for review. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels Apr 22, 2019
@eliorivero
eliorivero requested a review from jeherve April 22, 2019 18:46
@eliorivero
eliorivero requested a review from a team April 22, 2019 18:46
@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review This PR is ready for review. labels Apr 22, 2019
@eliorivero
eliorivero merged commit a9712b0 into master Apr 22, 2019
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Apr 22, 2019
@eliorivero
eliorivero deleted the add/settings-shortlinks branch April 22, 2019 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kraftbj kraftbj kraftbj approved these changes
@jeherve jeherve Awaiting requested review from jeherve

Assignees

@eliorivero eliorivero

Labels

Admin Page React-powered dashboard under the Jetpack menu Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Shortlinks

Projects

None yet

Milestone

7.3

Development

Successfully merging this pull request may close these issues.

Settings - Create WP.me shortlinks setting

5 participants

@eliorivero @jetpackbot @kraftbj @jeherve @matticbot