Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings - Traffic: add setting for Shortlinks #12093

Merged
merged 2 commits into from Apr 22, 2019

Conversation

eliorivero
Copy link
Contributor

Fixes #11935

Changes proposed in this Pull Request:

  • add a toggle for Shortlinks in the Traffic tab
  • make the setting searchable
  • remove searchable module
  • don't activate Shortlinks by default

Testing instructions:

  • Go to Jetpack settings, Traffic tab. Ensure the toggle is there, above Sitemaps
  • if Jetpack is in Development mode, the toggle must be disabled

Captura de Pantalla 2019-04-18 a la(s) 18 52 17

  • Verify it works as expected

Proposed changelog entry for your changes:

@eliorivero eliorivero added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review To request a review from Crew. Label will be renamed soon. Admin Page React-powered dashboard under the Jetpack menu labels Apr 18, 2019
@eliorivero eliorivero added this to the 7.3 milestone Apr 18, 2019
@eliorivero eliorivero requested a review from a team as a code owner April 18, 2019 21:56
@eliorivero eliorivero self-assigned this Apr 18, 2019
@eliorivero eliorivero added this to Inbox in Refining Module Prioritization via automation Apr 18, 2019
@eliorivero eliorivero moved this from Inbox to Needs review in Refining Module Prioritization Apr 18, 2019
@jetpackbot
Copy link

jetpackbot commented Apr 18, 2019

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: May 7, 2019.
Scheduled code freeze: April 30, 2019

Generated by 🚫 dangerJS against 4d12569

Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick note about the module toggle.

_inc/client/traffic/shortlinks.jsx Outdated Show resolved Hide resolved
@jeherve jeherve added [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Apr 19, 2019
…emove searchable module. Don't activate Shortlinks by default.
…cause this is a site-wide setting that doesn't rely on a user connection like After the Deadline does.
@eliorivero eliorivero added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Apr 22, 2019
@eliorivero eliorivero requested a review from jeherve April 22, 2019 18:46
@eliorivero eliorivero requested a review from a team April 22, 2019 18:46
@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Apr 22, 2019
@eliorivero eliorivero merged commit a9712b0 into master Apr 22, 2019
Refining Module Prioritization automation moved this from Needs review to Done Apr 22, 2019
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Apr 22, 2019
@eliorivero eliorivero deleted the add/settings-shortlinks branch April 22, 2019 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Admin Page React-powered dashboard under the Jetpack menu [Feature] Shortlinks [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Settings - Create WP.me shortlinks setting
5 participants