Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

About Page: remove submenu and add link to page in footer #12323

Merged
merged 3 commits into from
May 10, 2019
Merged

About Page: remove submenu and add link to page in footer #12323

merged 3 commits into from
May 10, 2019

Conversation

jeherve
Copy link
Member

@jeherve jeherve commented May 9, 2019 •
edited
Loading

Fixes #12315

Changes proposed in this Pull Request:

You can now access the About Page from 4 different locations:

  • The Automattic link at the bottom of the Jetpack dashboard pages.
  • The About link at the bottom of the Jetpack dashboard pages.
  • The Automattic logo on any Jetpack non-react admin pages (e.g. Settings > Sharing)
  • The about link at the bottom of any Jetpack non-react admin pages (e.g. Settings > Sharing)

Testing instructions:

  • Go to any of the pages I mentioned above?
  • Do you see the links?
  • Can you click on them, does the page open in the same tab?

Note:

  • If your site is connected to wpcom or in dev mode, the About link will lead to the in-plugin About page.
  • If you are not connected yet, the About link will lead to Jetpack.com.

Proposed changelog entry for your changes:

  • None

@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review To request a review from Crew. Label will be renamed soon. Admin Page React-powered dashboard under the Jetpack menu [Pri] Normal labels May 9, 2019
@jeherve jeherve added this to the 7.4 milestone May 9, 2019
@jeherve jeherve requested a review from a team as a code owner May 9, 2019 14:44
@jeherve jeherve self-assigned this May 9, 2019
@jeherve
About Page: remove submenu and add link to page in footer
d21645e 
Fixes #12315

You can now access the About Page from 4 different locations:

- The Automattic link at the bottom of the Jetpack dashboard pages.
- The About link at the bottom of the Jetpack dashboard pages.
- The Automattic logo on any Jetpack non-react admin pages (e.g. Settings > Sharing)
- The about link at the bottom of any Jetpack non-react admin pages (e.g. Settings > Sharing)
@jetpackbot
Copy link

jetpackbot commented May 9, 2019 •
edited
Loading

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: June 4, 2019.
Scheduled code freeze: May 28, 2019

Generated by 🚫 dangerJS against 1ddd5cc

eliorivero
eliorivero suggested changes May 9, 2019
View reviewed changes
Copy link
Contributor

@eliorivero eliorivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change requested, added code suggestion

_inc/lib/admin-pages/class.jetpack-admin-page.php Outdated Show resolved Hide resolved
@eliorivero eliorivero added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label May 9, 2019
@eliorivero
Copy link
Contributor

About page is no longer in the menu ✅

Captura de Pantalla 2019-05-09 a la(s) 15 42 48

It's in the footer and properly linked ✅

Captura de Pantalla 2019-05-09 a la(s) 15 43 05

Goes to blank page ❗️

Captura de Pantalla 2019-05-09 a la(s) 15 43 26

@eliorivero eliorivero added [Status] In Progress and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels May 9, 2019
@jeherve
Move path inside admin_url
6980877 
Props @eliorivero
#12323 (comment)
@jeherve
Only display link to About page when it is accessible.
1ddd5cc 
- If your site is connected to wpcom or in dev mode, the About link will lead to the in-plugin about page.
- If you are not connected yet, the About link will lead to Jetpack.com.

See #12323 (comment)
@jeherve jeherve added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] In Progress [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels May 9, 2019
@jeherve
Copy link
Member Author

jeherve commented May 9, 2019

Thanks for the feedback. This should be good for another review!

@eliorivero eliorivero added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels May 9, 2019
@eliorivero
Copy link
Contributor

🐑

@jeherve jeherve mentioned this pull request May 10, 2019
Closed
@jeherve jeherve merged commit 85d23f2 into master May 10, 2019
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels May 10, 2019
@jeherve jeherve deleted the update/about-page-links branch May 10, 2019 09:12
jeherve added a commit that referenced this pull request May 17, 2019
@jeherve
Changelog: add #12323
95a100e
jeherve added a commit that referenced this pull request May 23, 2019
@jeherve
Changelog: add #12323
c98c4c3
jeherve added a commit that referenced this pull request May 27, 2019
@kraftbj @jeherve
7.4 Changelog (#12304)
0fb4436 
* Kick off the changelog

* Add 7.3.1

* Update date and post link

* changelog: add #12219

* changelog: add #12170

* changelog: add #12184

* Changelog: add #12268

* Changelog: add #12081

* Changelog: add #12323

* Changelog: add #12204

* Changelog: add #12269

* Changelog: add #12332

* changelog: add #12339

* changelog: add #12209

* Changelog: add #12319

* Changelog: add #12357

* Changelog: add #12124

* Changelog: add #12373

* Changelog: add #12252

* Changelog: add #12383

* Changelog: add #12372

* changelog: add #12337

* Changelog: add #12290

* Changelog: add #12301

* Changelog: add #12061

* Testing list: add instructions for #12061

* Changelog: add #12393

* Update minimum supported version

See #12287

* Changelog: add #12406

* Testing list: add #12406

* Changelog: add #12277

* Changelog: add #12412

* Changelog: add #11318

* Changelog: add #12328

* Changelog: add #12425

* Changelog: add #12380

* Changelog: add #12428

* Changelog: add #12414

* Changelog: add #12395

* Changelog & Testing list: add #12416, #12417, #12418, and #12348

* changelog: add #12379

* Changelog: add #12341

* changelog: add #12444

* Changelog: add #12434

* Changelog: add #12454

* Changelog: add #12460

* Changelog: add #12463

* Changelog: add #12457

* Changelog / testing list: add #10333

* Changelog: add #12467


Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>
jeherve added a commit that referenced this pull request Sep 4, 2019
@jeherve
About Page: remove menu order changes since we removed the submenu
4b01e56 
We do not need to reorder the menu item anymore since we got rid of that menu item in #12323.
@jeherve jeherve mentioned this pull request Sep 4, 2019
Merged
jeherve added a commit that referenced this pull request Sep 19, 2019
@jeherve
About Page: remove menu order changes since we removed the sub… (#13425)
e915c5a 
We do not need to reorder the menu item anymore since we got rid of that menu item in #12323.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eliorivero eliorivero eliorivero approved these changes

@jeffgolenski jeffgolenski Awaiting requested review from jeffgolenski

@crunnells crunnells Awaiting requested review from crunnells

Assignees

@jeherve jeherve

Labels
Admin Page React-powered dashboard under the Jetpack menu [Pri] Normal [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
7.4
Development

Successfully merging this pull request may close these issues.

Jetpack About Page: Remove sidebar link, Add footer link
4 participants
@jeherve @jetpackbot @eliorivero @matticbot