Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit Tests: Add support for VVV 3.0's path. #12434

Merged
merged 1 commit into from
May 23, 2019
Merged

Conversation

kraftbj
Copy link
Contributor

@kraftbj kraftbj commented May 21, 2019

Requires the wordpress-trunk site to be provisioned on VVV 3 and the tests config file added.

Split off of #12410

Changes proposed in this Pull Request:

  • Adds support for unit testing with VVV 3.0

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • n/a

Testing instructions:

  • Install latest VVV (3.0).
  • Edit your vvv-custom.yml to set "skip provision" to false for the wordpress-trunk site.
  • vagrant up --provision
  • Add a wp-tests-config.php file to /srv/www/wordpress-trunk/public_html that uses the same creds as wp-config.php with a db name of wordpress_unit_tests
  • Run phpunit from the jetpack root directory. (e.g. /srv/www/wordpress-trunk/public_html/build/wp-content/plugins/jetpack/ or /srv/www/wordpress-one/public_html/wp-content/plugins/jetpack/

Proposed changelog entry for your changes:

  • Unit Tests: Add support for testing using VVV 3.0.

@kraftbj kraftbj added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review To request a review from Crew. Label will be renamed soon. Unit Tests labels May 21, 2019
@kraftbj kraftbj added this to the 7.4 milestone May 21, 2019
@kraftbj kraftbj requested a review from gravityrail May 21, 2019 19:30
@kraftbj kraftbj requested a review from a team as a code owner May 21, 2019 19:30
@jetpackbot
Copy link

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: June 4, 2019.
Scheduled code freeze: May 28, 2019

Generated by 🚫 dangerJS against 474ed92

Copy link
Member

@jeherve jeherve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels May 23, 2019
@kraftbj kraftbj merged commit 0e3bd0e into master May 23, 2019
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels May 23, 2019
@kraftbj kraftbj deleted the update/phpunit-vvv-3 branch May 23, 2019 21:41
jeherve added a commit that referenced this pull request May 24, 2019
jeherve added a commit that referenced this pull request May 27, 2019
* Kick off the changelog

* Add 7.3.1

* Update date and post link

* changelog: add #12219

* changelog: add #12170

* changelog: add #12184

* Changelog: add #12268

* Changelog: add #12081

* Changelog: add #12323

* Changelog: add #12204

* Changelog: add #12269

* Changelog: add #12332

* changelog: add #12339

* changelog: add #12209

* Changelog: add #12319

* Changelog: add #12357

* Changelog: add #12124

* Changelog: add #12373

* Changelog: add #12252

* Changelog: add #12383

* Changelog: add #12372

* changelog: add #12337

* Changelog: add #12290

* Changelog: add #12301

* Changelog: add #12061

* Testing list: add instructions for #12061

* Changelog: add #12393

* Update minimum supported version

See #12287

* Changelog: add #12406

* Testing list: add #12406

* Changelog: add #12277

* Changelog: add #12412

* Changelog: add #11318

* Changelog: add #12328

* Changelog: add #12425

* Changelog: add #12380

* Changelog: add #12428

* Changelog: add #12414

* Changelog: add #12395

* Changelog & Testing list: add #12416, #12417, #12418, and #12348

* changelog: add #12379

* Changelog: add #12341

* changelog: add #12444

* Changelog: add #12434

* Changelog: add #12454

* Changelog: add #12460

* Changelog: add #12463

* Changelog: add #12457

* Changelog / testing list: add #10333

* Changelog: add #12467


Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug When a feature is broken and / or not performing as intended Unit Tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants