Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack DNA: Move Sync Menus Module from Legacy to PSR-4 #12743

Merged
merged 5 commits into from Jun 20, 2019

Conversation

gititon
Copy link
Contributor

@gititon gititon commented Jun 18, 2019

This PR moves the sync menus module from legacy to PSR-4.

No new tests should be needed because this is a refactor, so existing tests should catch any regressions.

@jetpackbot
Copy link

jetpackbot commented Jun 18, 2019

Warnings
⚠️ "Testing instructions" are missing for this PR. Please add some
⚠️ "Proposed changelog entry" is missing for this PR. Please include any meaningful changes

This is an automated check which relies on PULL_REQUEST_TEMPLATE. We encourage you to follow that template as it helps Jetpack maintainers do their job. If you think 'Testing instructions' or 'Proposed changelog entry' are not needed for your PR - please explain why you think so. Thanks for cooperation 🤖

Generated by 🚫 dangerJS against ece0bd5

@gititon gititon added [Status] Needs Review To request a review from Crew. Label will be renamed soon. and removed [Status] In Progress labels Jun 18, 2019
@gititon gititon requested a review from a team June 18, 2019 21:35
@gititon gititon requested a review from a team as a code owner June 19, 2019 17:47
@lezama lezama merged commit 11c45ba into master Jun 20, 2019
@lezama lezama deleted the dna-menus-module branch June 20, 2019 09:58
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Jun 20, 2019
@jeherve jeherve added this to the 7.5 milestone Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants