Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Blocks: Show Blocks if they're missing a plan, add Upgrade Nudge #12823
Picking up @scruffian's Automattic/wp-calypso#33723 and moving it into JP.
Changes proposed in this Pull Request:
Enable paid blocks on plans that don't include them for insertion into the editor, and add an upgrade nudge to them. Feature-flagged for now.
Is this a new feature or does it add/remove features to an existing part of Jetpack?
Styling pending some help from a designer
Once this PR has approval, I'll manually sync the newly created files over to the WP.com counterpart, D29733-code. Doing that now doesn't make sense since they'll be removed by Fusion each time this PR changes.
Proposed changelog entry for your changes:
Enable paid blocks on plans that don't include them for insertion into the editor, and add an upgrade nudge to them.
Don't forget that this is WP.com first -- we'll probably even add a check to hide it from JP for now. This is mostly relevant for the upgrade flow.
Thank you for the great PR description!
When this PR is ready for review, please apply the
Scheduled Jetpack release: August 6, 2019.
1 similar comment
Not sure why, but I landed on the checkout page. with Premium plan added to my card. After checkout, I was redirected to the onboarding checklist, which I would not expect to see. We opening upgrade flow in the same editor's tab, so I would expect that flow will land me into my post editor.
Correct — this PR is a generic solution that can be extended for all premium blocks but implemented initially just for Simple payments.
Yep, as well as for VideoPress and WordAds but those will need little more work. See paAmJe-uG-p2 for context.
Jul 4, 2019
That was changed last minute and was expected
Heh, sorry, Calypso side is still pending merging. Automattic/wp-calypso#34440 :-)