Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection: Implement disconnect_user in the connection package #13220

Merged
merged 9 commits into from Aug 19, 2019

Conversation

tyxla
Copy link
Member

@tyxla tyxla commented Aug 13, 2019

This PR implements the disconnect_user in the connection package. This method was previously implemented in the Jetpack class and wasn't yet implemented in the connection package.

We also update old method usage to use the new connection manager method, and deprecate the old method in favor of the new one.

Changes proposed in this Pull Request:

  • Connection: Update docs of Manager_Interface::disconnect_user
  • Connection: Implement Manager::disconnect_user()
  • Connection: Deprecate Jetpack::unlink_user in favor of the connection package
  • Connection: Add todos to refactor XMLRPC client loading
  • Connection: Use Manager::disconnect_user in Jetpack class
  • Connection: Use Manager::disconnect_user in Jetpack CLI
  • Connection: Use Manager::disconnect_user in core REST API endpoints
  • Connection: Use Manager::disconnect_user in XMLRPC server

Is this a new feature or does it add/remove features to an existing part of Jetpack?

  • This is a continuation of this effort: p1HpG7-7lI-p2

Testing instructions:

  • A secondary user in this context is a user that is connected to WP.com but is not the master user / connection owner.
  • Disconnect a secondary user from WP.com and make sure it goes correctly without any errors.
  • Disconnect a secondary user from WP admin and make sure it goes correctly without any errors.
  • Disconnect a secondary user using WP CLI and make sure it goes correctly without any errors.
  • Make sure all tests still pass.

Proposed changelog entry for your changes:

  • Connection: Implement Manager::disconnect_user()
  • Connection: Deprecate Jetpack::unlink_user in favor of the connection package
  • Connection: Use Manager::disconnect_user instead of Jetpack::unlink_user everywhere.

@tyxla tyxla added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Review To request a review from Crew. Label will be renamed soon. Connect Flow Connection banners, buttons, ... [Focus] Jetpack DNA labels Aug 13, 2019
@tyxla tyxla added this to the 7.7 milestone Aug 13, 2019
@tyxla tyxla requested review from a team August 13, 2019 12:39
@tyxla tyxla self-assigned this Aug 13, 2019
@jetpackbot
Copy link

jetpackbot commented Aug 13, 2019

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Scheduled Jetpack release: September 3, 2019.
Scheduled code freeze: August 27, 2019

Generated by 🚫 dangerJS against c004420

Copy link
Contributor

@lezama lezama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! I like disconnect_user much more.

🚢 IT!

@tyxla tyxla merged commit ca302c4 into master Aug 19, 2019
@tyxla tyxla deleted the implement/connection-manager-disconnect-user branch August 19, 2019 09:36
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Connect Flow Connection banners, buttons, ... [Focus] Jetpack DNA [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants