New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Connection: Implement disconnect_user in the connection package #13220
Conversation
Thank you for the great PR description! When this PR is ready for review, please apply the Scheduled Jetpack release: September 3, 2019. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! I like disconnect_user
much more.
🚢 IT!
This PR implements the
disconnect_user
in the connection package. This method was previously implemented in theJetpack
class and wasn't yet implemented in the connection package.We also update old method usage to use the new connection manager method, and deprecate the old method in favor of the new one.
Changes proposed in this Pull Request:
Manager_Interface::disconnect_user
Manager::disconnect_user()
Jetpack::unlink_user
in favor of the connection packageManager::disconnect_user
in Jetpack classManager::disconnect_user
in Jetpack CLIManager::disconnect_user
in core REST API endpointsManager::disconnect_user
in XMLRPC serverIs this a new feature or does it add/remove features to an existing part of Jetpack?
Testing instructions:
Proposed changelog entry for your changes:
Manager::disconnect_user()
Jetpack::unlink_user
in favor of the connection packageManager::disconnect_user
instead ofJetpack::unlink_user
everywhere.