New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
External Media: Enable for Cover block #17441
Conversation
Caution: This PR has changes that must be merged to WordPress.com |
@marekhrabe @retrofox Do you remember why we initially decided to not make External Media available to the Cover block? |
Scheduled Jetpack release: November 3, 2020. E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-17441 Thank you for the great PR description! When this PR is ready for review, please apply the |
Was no valid reason, AFAIK. I presume it was just a way to extend the media button progressively to other blocks. Add it to cover makes total sense to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r215148-wpcom |
Enables External Media feature for the Cover block.
Changes proposed in this Pull Request:
core/cover
to the list of blocks External Media is available to.Does this pull request change what data or activity we track or use?
No
Testing instructions:
Proposed changelog entry for your changes: