Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External Media: Enable for Cover block #17441

Merged
merged 1 commit into from Oct 13, 2020

Conversation

obenland
Copy link
Member

@obenland obenland commented Oct 9, 2020

Enables External Media feature for the Cover block.

Changes proposed in this Pull Request:

  • Adds core/cover to the list of blocks External Media is available to.

Does this pull request change what data or activity we track or use?

No

Testing instructions:

  • In the Editor, insert a Cover block and chose an External Media provider to insert a background image.
  • Replace the image with a different one.

Proposed changelog entry for your changes:

  • Makes External Media available to the Cover block.

@obenland obenland added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Needs Team Review [Extension] External Media Extend all block editor media tools to support external providers labels Oct 9, 2020
@obenland obenland requested a review from a team October 9, 2020 20:06
@matticbot
Copy link
Contributor

Caution: This PR has changes that must be merged to WordPress.com
Hello obenland! These changes need to be synced to WordPress.com - If you 're an a11n, please commandeer and confirm D50959-code works as expected before merging this PR. Once this PR is merged, please commit the changes to WP.com. Thank you!
This revision will be updated with each commit to this PR

@obenland
Copy link
Member Author

obenland commented Oct 9, 2020

@marekhrabe @retrofox Do you remember why we initially decided to not make External Media available to the Cover block?

@jetpackbot
Copy link

Scheduled Jetpack release: November 3, 2020.
Scheduled code freeze: October 27, 2020

E2E results is available here (for debugging purposes): https://jetpack-e2e-dashboard.herokuapp.com/pr-17441

Thank you for the great PR description!

When this PR is ready for review, please apply the [Status] Needs Review label. If you are an a11n, please have someone from your team review the code if possible. The Jetpack team will also review this PR and merge it to be included in the next Jetpack release.

Generated by 🚫 dangerJS against 53c834e

@retrofox
Copy link
Contributor

retrofox commented Oct 9, 2020

@marekhrabe @retrofox Do you remember why we initially decided to not make External Media available to the Cover block?

Was no valid reason, AFAIK. I presume it was just a way to extend the media button progressively to other blocks. Add it to cover makes total sense to me.

Copy link
Contributor

@retrofox retrofox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

image

@jeherve jeherve added this to the 9.1 milestone Oct 12, 2020
@jeherve jeherve added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Team Review labels Oct 12, 2020
@obenland obenland merged commit 2619839 into master Oct 13, 2020
@obenland obenland deleted the update/external-media-allowed-blocks branch October 13, 2020 18:40
@matticbot matticbot added [Status] Needs Changelog and removed [Status] Ready to Merge Go ahead, you can push that green button! labels Oct 13, 2020
@obenland
Copy link
Member Author

r215148-wpcom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Extension] External Media Extend all block editor media tools to support external providers Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants