-
Notifications
You must be signed in to change notification settings - Fork 841
Duplicate views: Add util to fetch experiment assignment #40471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+72
−0
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c990445
Duplicate views: Add util to fetch experiment assignment
mmtr 917ad33
Refactor code
BogdanUngureanu f80aeb9
Fix for simple sites
mmtr 5762c7b
Further optimizations
mmtr b02a9fd
Merge remote-tracking branch 'origin/trunk' into add/duplicate-views-…
mmtr 67e757b
Return static variable if it's been initialized with a boolean
mmtr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
4 changes: 4 additions & 0 deletions
4
projects/packages/jetpack-mu-wpcom/changelog/add-duplicate-views-assignment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| Significance: patch | ||
| Type: added | ||
|
|
||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The endpoint will return
nullfor the default experience, but it will also return null if the experiment is in staging. This means we will be caching the null experience for any existing users that have triggered this code, so it will skip the actual assignment, meaning we will only be testing users that haven't triggered this code before we started the experiment. Since this code has been in place for a while that might roughly mean existing users in general, and so we are only testing new or newly active users.By caching here it also means the ExPlat experiment controls to disable an experiment won't work correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, we identified this issue recently (p1736776189483689-slack-C04DZ8M0GHW, Automattic/wp-calypso#98341) and prepared a quick fix to bust the cached assignment 😄 (#41093)