New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always load the sync listener #5476
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helps to avoid edge cases where modifications happen but we don’t find out because the listener didn’t load.
gravityrail
added
[Status] Needs Review
To request a review from Crew. Label will be renamed soon.
[Team] Poseidon
[Package] Sync
labels
Nov 1, 2016
gravityrail
removed
the
[Status] Needs Review
To request a review from Crew. Label will be renamed soon.
label
Nov 1, 2016
jeherve
added a commit
that referenced
this pull request
Nov 10, 2016
Changelog: add #5186 Changelog: add #3425 Changelog: add #5365 Changelog: add #5428 Changelog: add #3358 Changelog: add #5183 Changelog: add #4881 Changelog: add #5286 Changelog: add #5395 Changelog: add #5419 Changelog: add #5437 Changelog: add #5291 Update version number Changelog: add #5476, #5413, #5409, #5355, #5348 Changelog: add #5381 Changelog: add #5412 Changelog: add #5386 Changelog: add #5250 CHangelog: add #5011 Changelog: add #5090 Changelog: add IDC fixes. Changelog: add #5259 CHangelog: add #5186 Changelog: add #5236 Changelog: add #5284 Changelog: add #5366 Changelog: add #5382 Changelog: add #5396 Changelog: add #5405 Changelog: add #4897 Changelog: add #5289 Added a changelog entry about #5534. Added a changelog entry about #5479. Added a changelog entry about #5454. Added a changelog entry about #5434. Added a changelog entry about #5408. Added a changelog entry about #5369. Added a changelog entry about #5350. Added a changelog entry about #5324. Added a changelog entry about #5319. Added a changelog entry about #5310. Added a changelog entry about #5282. Added a changelog entry about #5176. Added a changelog entry about #3515. Added a changelog entry about #1542. Added a changelog entry about #5316. Added a changelog entry about #3188. Changelog: add #4987 Changelog: add #5270 Changelog: add #5225 Changelog: add #5507 Changelog: add #5432 Changelog: add #5473 Changelog: add #5392 Changelog: add #5222 Changelog: add #5457 Changelog: add #5423 Changelog: add #5332 Changelog: add #3853 Changelog: add #5237 Changelog: add #5307 Changelog: move up release headliner. Changelog: add #5375 CHangelog: add #5496 Changelog: add #5528 Changelog: add #5537 Changelog: remove new Settings, they're punted to 4.5. Changelog: move release headliner to the top. Changelog: add testing list. Changelog: add #4953 Changelog: add #5575 Changelog: add #5573 Changelog: add #5345
zinigor
pushed a commit
that referenced
this pull request
Nov 10, 2016
* Changelog: add PRs belonging to 4.4. Changelog: add #5186 Changelog: add #3425 Changelog: add #5365 Changelog: add #5428 Changelog: add #3358 Changelog: add #5183 Changelog: add #4881 Changelog: add #5286 Changelog: add #5395 Changelog: add #5419 Changelog: add #5437 Changelog: add #5291 Update version number Changelog: add #5476, #5413, #5409, #5355, #5348 Changelog: add #5381 Changelog: add #5412 Changelog: add #5386 Changelog: add #5250 CHangelog: add #5011 Changelog: add #5090 Changelog: add IDC fixes. Changelog: add #5259 CHangelog: add #5186 Changelog: add #5236 Changelog: add #5284 Changelog: add #5366 Changelog: add #5382 Changelog: add #5396 Changelog: add #5405 Changelog: add #4897 Changelog: add #5289 Added a changelog entry about #5534. Added a changelog entry about #5479. Added a changelog entry about #5454. Added a changelog entry about #5434. Added a changelog entry about #5408. Added a changelog entry about #5369. Added a changelog entry about #5350. Added a changelog entry about #5324. Added a changelog entry about #5319. Added a changelog entry about #5310. Added a changelog entry about #5282. Added a changelog entry about #5176. Added a changelog entry about #3515. Added a changelog entry about #1542. Added a changelog entry about #5316. Added a changelog entry about #3188. Changelog: add #4987 Changelog: add #5270 Changelog: add #5225 Changelog: add #5507 Changelog: add #5432 Changelog: add #5473 Changelog: add #5392 Changelog: add #5222 Changelog: add #5457 Changelog: add #5423 Changelog: add #5332 Changelog: add #3853 Changelog: add #5237 Changelog: add #5307 Changelog: move up release headliner. Changelog: add #5375 CHangelog: add #5496 Changelog: add #5528 Changelog: add #5537 Changelog: remove new Settings, they're punted to 4.5. Changelog: move release headliner to the top. Changelog: add testing list. Changelog: add #4953 Changelog: add #5575 Changelog: add #5573 Changelog: add #5345 * Changelog: add #5168
samhotchkiss
pushed a commit
that referenced
this pull request
Nov 11, 2016
* Changelog: add PRs belonging to 4.4. Changelog: add #5186 Changelog: add #3425 Changelog: add #5365 Changelog: add #5428 Changelog: add #3358 Changelog: add #5183 Changelog: add #4881 Changelog: add #5286 Changelog: add #5395 Changelog: add #5419 Changelog: add #5437 Changelog: add #5291 Update version number Changelog: add #5476, #5413, #5409, #5355, #5348 Changelog: add #5381 Changelog: add #5412 Changelog: add #5386 Changelog: add #5250 CHangelog: add #5011 Changelog: add #5090 Changelog: add IDC fixes. Changelog: add #5259 CHangelog: add #5186 Changelog: add #5236 Changelog: add #5284 Changelog: add #5366 Changelog: add #5382 Changelog: add #5396 Changelog: add #5405 Changelog: add #4897 Changelog: add #5289 Added a changelog entry about #5534. Added a changelog entry about #5479. Added a changelog entry about #5454. Added a changelog entry about #5434. Added a changelog entry about #5408. Added a changelog entry about #5369. Added a changelog entry about #5350. Added a changelog entry about #5324. Added a changelog entry about #5319. Added a changelog entry about #5310. Added a changelog entry about #5282. Added a changelog entry about #5176. Added a changelog entry about #3515. Added a changelog entry about #1542. Added a changelog entry about #5316. Added a changelog entry about #3188. Changelog: add #4987 Changelog: add #5270 Changelog: add #5225 Changelog: add #5507 Changelog: add #5432 Changelog: add #5473 Changelog: add #5392 Changelog: add #5222 Changelog: add #5457 Changelog: add #5423 Changelog: add #5332 Changelog: add #3853 Changelog: add #5237 Changelog: add #5307 Changelog: move up release headliner. Changelog: add #5375 CHangelog: add #5496 Changelog: add #5528 Changelog: add #5537 Changelog: remove new Settings, they're punted to 4.5. Changelog: move release headliner to the top. Changelog: add testing list. Changelog: add #4953 Changelog: add #5575 Changelog: add #5573 Changelog: add #5345 * Changelog: add #5168
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The sync listener (which listens for changes to the DB and stores them to the sync queue) doesn't always load - it tries to only load during cases where we are likely to modify data.
However this means that data modified from PHP scripts, wp cli, and potentially many other places doesn't get synced. This could interfere with proper operation of things like subscriptions and publicize, where we need to be guaranteed that data will be saved at the moment a post is published.
This PR changes it to always load. Only occasionally loading was probably premature optimisation, given that the overhead of loading the listener is very small.
cc @lezama @enejb