Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widgets: trim spaces in the URLs entered in Image and Display WordPress Posts #6375

Merged
merged 1 commit into from Feb 13, 2017
Merged

Widgets: trim spaces in the URLs entered in Image and Display WordPress Posts #6375

merged 1 commit into from Feb 13, 2017

Conversation

eliorivero
Copy link
Contributor

Fixes #6328

Changes proposed in this Pull Request:

  • Image: trim spaces before escaping the URL so esc_url doesn't convert it to %20 and fail the regexp that checks the formatting.
  • Display WordPress Posts: trim spaces so the preg_replace doesn't remove the URL due to the wrong start

Testing instructions:

  • Add an Image widget and enter a URL that has a space at the beginning so it's invalid. It should be stripped and the URL should be correct.
  • Add an Display WordPress Posts widget and enter a URL that has a space at the beginning so it's invalid. It should be stripped and the URL should be correct.

Proposed changelog entry for your changes:

Widgets: if URLs are entered in Image and Display WordPress Posts widgets with spaces inadvertently added at the beginning, remove them so the URL begins correctly and is not rejected.

@eliorivero
Widgets: trim spaces before escaping the URL so esc_url doesn't conve…
e3093b9 
…rt it to %20 and fail the regexp that checks the formatting.
@eliorivero eliorivero added [Feature] Extra Sidebar Widgets [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it labels Feb 10, 2017
@eliorivero eliorivero self-assigned this Feb 10, 2017
@eliorivero eliorivero force-pushed the update/image-widget-trim-url-spaces branch from 4c9e2f7 to e3093b9 Compare February 10, 2017 22:36
dereksmart
dereksmart approved these changes Feb 11, 2017
View reviewed changes
Copy link
Member

@dereksmart dereksmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dereksmart dereksmart added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Feb 11, 2017
georgestephanis
georgestephanis approved these changes Feb 13, 2017
View reviewed changes
Copy link
Member

@georgestephanis georgestephanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

@eliorivero eliorivero merged commit 5da81fb into master Feb 13, 2017
@eliorivero eliorivero deleted the update/image-widget-trim-url-spaces branch February 13, 2017 13:42
@eliorivero eliorivero removed the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 13, 2017
jeherve added a commit that referenced this pull request Feb 21, 2017
@jeherve
Changelog: add #6375
58d59e1
dereksmart pushed a commit that referenced this pull request Feb 28, 2017
@jeherve @dereksmart
Jetpack 4.7: Changelog (#6331)
a9adf86 
* Changelog: update stable tag and move changelog to changelog.txt

Also remove old releases from readme.txt to keep the changelog tab short.

* Changelog: add #5883

Also update the filter's docblock to match new version.

* Changelog: add #5938

* Changelog: add #6298

* Changelog: add #3405

* Changelog: add #5941

* Changelog: add #6239

* Changelog: add #6281

* Changelog: add #6303

* Changelog: add #6018

* Changelog: add #6300

* Changelog: add #6296

* Changelog: add #6130

* Changelog: add #6292

* Readme: remove extra "on".

* Changelog: add #6307

* Changelog: add #3297

* Changelog: add #6275

* Changelog: add #6321

* Changelog: add #6297

* Readme: update the support forum link anchor.

Anchor changed when WordPress.org forums were updated to bbPress 2

* Readme: update list of a12s, it wasn't up to date anymore!

* Changelog: add #6338

* Changelog: add #6337

* Changelog: add #6335

* Changelog: add #6333

* Testing List: first version of the 4.7 testing list.

* Changelog: add #6332

* Changelog: add #6325

* Changelog: add #6326

* Changelog: add #6339

* Changelog: add #6342

* Changelog: add #6343

* Changelog: add #6346

* Changelog: add #6347

* Changelog: add #6279

* Changelog: add #6306

* Changelog: add #6312

* Changelog: add #6316

* Changelog: add #6171

* Changelog: add #6317

* Changelog: add #6246

* Changelog: add #6263

* Changelog: add #4220

* Changelog: add #5888

* Changelog: add #3406

* Changelog: add #3637

* Changelog: add #6320

* Changelog: add #5992

* Changelog: add #6322

* Changelog: add #6324

* Changelog: add #6352

* Changelog: add #6355

* Changelog: add #6360

* Changelog: add #6362

* Changelog: add #6369, #6382

* Changelog: add #6370

* Changelog: add #6375

* Changelog: add #6383

* Changelog: add #6384

* Changelog: add #6386

* Changelog: add #6395

* Changelog: add #6403

* Changelog: add #6406

* Changelog: add #6418

* Changelog: add #6419

* Changelog: add #6434

* Changelog: add #6446

* Changelog: add #6006

* Changelog: add #6096

* Changelog: add #6399

* Changelog: fix typo.

@see #6331 (comment)

* Changelog: add #6440

* Changelog: add #6443

* Changelog: add #6445

* Changelog: add #6463

* Changelog: add #6468

* Changelog: add #6471

* Changelog: add #6474

* Changelog: add #6480

* Changelog: add #6497

* Changelog: add #6499

* Changelog: add #6514

* Changelog: add #6267

* Changelog: add #5940

* Changelog: add #6492

* Changelog: add #5281

* Changelog: add #6327

* Changelog: add #6451

* Changelog: add #6525

* Changelog: add #6530
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgestephanis georgestephanis georgestephanis approved these changes

@dereksmart dereksmart dereksmart approved these changes

Assignees

@eliorivero eliorivero

Labels
[Feature] Extra Sidebar Widgets Touches WP.com Files [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@eliorivero @georgestephanis @dereksmart @jeherve @matticbot