Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Endpoints: allow to toggle Markdown for posts independent of comments #6406

Merged
merged 1 commit into from Feb 14, 2017
Merged

Endpoints: allow to toggle Markdown for posts independent of comments #6406

merged 1 commit into from Feb 14, 2017

Conversation

eliorivero
Copy link
Contributor

@eliorivero eliorivero commented Feb 14, 2017 •
edited

Changes proposed in this Pull Request:

  • whitelist option for Markdown for posts.
  • remove code in markdown.php that forcefully enables Markdown for posts every time the option is attempted to be written.

Testing instructions:

  • Calls to wp-json/jetpack/v4/settings passing true or false for wpcom_publish_posts_with_markdown should succeed in toggling it on and off.

Proposed changelog entry for your changes:

Endpoints: allow to independently toggle Markdown for posts

@eliorivero
Endpoints: whitelist option for Markdown for posts. Remove code that …
8642a16 
…forcefully enables Markdown for posts every time the option is about to be written.
@eliorivero eliorivero added Admin Page React-powered dashboard under the Jetpack menu [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it labels Feb 14, 2017
@eliorivero eliorivero self-assigned this Feb 14, 2017
@eliorivero eliorivero mentioned this pull request Feb 14, 2017
Merged
tyxla
tyxla approved these changes Feb 14, 2017
View reviewed changes
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, thank you 👍

@tyxla tyxla added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. labels Feb 14, 2017
@samhotchkiss samhotchkiss merged commit ea8c553 into master Feb 14, 2017
@samhotchkiss samhotchkiss removed the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 14, 2017
@samhotchkiss samhotchkiss deleted the update/endpoint-whitelist-markdown-posts-independent branch February 14, 2017 19:15
@aheckler aheckler mentioned this pull request Feb 18, 2017
Closed
jeherve added a commit that referenced this pull request Feb 21, 2017
@jeherve
Changelog: add #6406
877a784
dereksmart pushed a commit that referenced this pull request Feb 28, 2017
@jeherve @dereksmart
Jetpack 4.7: Changelog (#6331)
a9adf86 
* Changelog: update stable tag and move changelog to changelog.txt

Also remove old releases from readme.txt to keep the changelog tab short.

* Changelog: add #5883

Also update the filter's docblock to match new version.

* Changelog: add #5938

* Changelog: add #6298

* Changelog: add #3405

* Changelog: add #5941

* Changelog: add #6239

* Changelog: add #6281

* Changelog: add #6303

* Changelog: add #6018

* Changelog: add #6300

* Changelog: add #6296

* Changelog: add #6130

* Changelog: add #6292

* Readme: remove extra "on".

* Changelog: add #6307

* Changelog: add #3297

* Changelog: add #6275

* Changelog: add #6321

* Changelog: add #6297

* Readme: update the support forum link anchor.

Anchor changed when WordPress.org forums were updated to bbPress 2

* Readme: update list of a12s, it wasn't up to date anymore!

* Changelog: add #6338

* Changelog: add #6337

* Changelog: add #6335

* Changelog: add #6333

* Testing List: first version of the 4.7 testing list.

* Changelog: add #6332

* Changelog: add #6325

* Changelog: add #6326

* Changelog: add #6339

* Changelog: add #6342

* Changelog: add #6343

* Changelog: add #6346

* Changelog: add #6347

* Changelog: add #6279

* Changelog: add #6306

* Changelog: add #6312

* Changelog: add #6316

* Changelog: add #6171

* Changelog: add #6317

* Changelog: add #6246

* Changelog: add #6263

* Changelog: add #4220

* Changelog: add #5888

* Changelog: add #3406

* Changelog: add #3637

* Changelog: add #6320

* Changelog: add #5992

* Changelog: add #6322

* Changelog: add #6324

* Changelog: add #6352

* Changelog: add #6355

* Changelog: add #6360

* Changelog: add #6362

* Changelog: add #6369, #6382

* Changelog: add #6370

* Changelog: add #6375

* Changelog: add #6383

* Changelog: add #6384

* Changelog: add #6386

* Changelog: add #6395

* Changelog: add #6403

* Changelog: add #6406

* Changelog: add #6418

* Changelog: add #6419

* Changelog: add #6434

* Changelog: add #6446

* Changelog: add #6006

* Changelog: add #6096

* Changelog: add #6399

* Changelog: fix typo.

@see #6331 (comment)

* Changelog: add #6440

* Changelog: add #6443

* Changelog: add #6445

* Changelog: add #6463

* Changelog: add #6468

* Changelog: add #6471

* Changelog: add #6474

* Changelog: add #6480

* Changelog: add #6497

* Changelog: add #6499

* Changelog: add #6514

* Changelog: add #6267

* Changelog: add #5940

* Changelog: add #6492

* Changelog: add #5281

* Changelog: add #6327

* Changelog: add #6451

* Changelog: add #6525

* Changelog: add #6530
jeherve added a commit that referenced this pull request Mar 8, 2017
@jeherve
Markdown: enable for posts whenever the module is active.
d528053 
Also remove the option from Settings > Writing.

Fixes #6605

Related:
- #6406
- #6548
@jeherve jeherve mentioned this pull request Mar 8, 2017
Merged
dereksmart pushed a commit that referenced this pull request Mar 9, 2017
@jeherve @dereksmart
Markdown: enable for posts whenever the module is active. (#6608)
73f17b2 
* Markdown: enable for posts whenever the module is active.

Also remove the option from Settings > Writing.

Fixes #6605

Related:
- #6406
- #6548

* Markdown: make sure posts markdown is re-enabled on upgrade

* Remove setting checkbox from writing options page
dereksmart pushed a commit that referenced this pull request Mar 9, 2017
@jeherve @dereksmart
Markdown: enable for posts whenever the module is active. (#6608)
71752a9 
* Markdown: enable for posts whenever the module is active.

Also remove the option from Settings > Writing.

Fixes #6605

Related:
- #6406
- #6548

* Markdown: make sure posts markdown is re-enabled on upgrade

* Remove setting checkbox from writing options page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyxla tyxla tyxla approved these changes

Assignees

@eliorivero eliorivero

Labels
Admin Page React-powered dashboard under the Jetpack menu [Feature] WP REST API [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eliorivero @tyxla @jeherve @samhotchkiss