Minify more JS #8329
Merged
Minify more JS #8329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gravityrail
added
[Status] Needs Review
|
This is ready to review |
ebinnion
approved these changes
Dec 7, 2017
class.photon.php
Outdated
| 'jetpack-photon', | ||
| Jetpack::get_file_url_for_environment( | ||
| '_inc/build/photon/photon.min.js', | ||
| plugins_url( 'modules/photon/photon.js', JETPACK__PLUGIN_FILE ) |
There was a problem hiding this comment.
When define( 'SCRIPT_DEBUG', true ); is set, I'm getting a 404 for this file. I believe this line should just be modules/photon/photon.js.
gravityrail
removed
the
[Status] Needs Review
jeherve
added
[Status] Needs Changelog
[Status] Needs Testing
dereksmart
pushed a commit
that referenced
this pull request
May 2, 2018
Summary: This merges this commit to the css file - adbde22 It also includes manual resolution for the divergent files: - `mu-plugins/carousel/jetpack-carousel.php` - significant commits: - #5469 - 728c96f - 4b70301 - 7fc7ebd - b4ad963 - adbde22 - `mu-plugins/carousel/jetpack-carousel.js` - significant commits: - #8329 - #7943 - #8509 Test Plan: Steps: - Add an gallery widget to a site. - Click on an image in the gallery - The carousel should open and the navigation should work as expect. - Check the dev console for any JS errors Reviewers: dereksmart, zinigor Reviewed By: zinigor Subscribers: zinigor, brbrr, dereksmart Differential Revision: https://[private link] Merges r174217-wpcom.
dereksmart
added a commit
that referenced
this pull request
May 2, 2018
* Likes: update Carousel to remove Likes support, to match Jetpack. Resolve divergences from Jetpack as well for related files. Fixes #7133. Merges r133276-wpcom. * Carousel: better Jetpack JS hiding, see r133276. Merges r133288-wpcom. * Carousel: revert part of r133276 where galleries are auto closed. Reported in Slack: https://a8c.slack.com/archives/triage/p1459368181000158 Jetpack related change: 36e529d Merges r133533-wpcom. * Jetpack: Sync carousel module changes Summary: @michiecat mentioned today that a client was having an issue where opening a gallery, closing a gallery, and then clicking the back button was reopening the gallery. It looks like we have fixed this in Jetpack, but we need to sync those changes back to WPCOM so our WP.com and VIP users can get those changes. Test Plan: Check out patch. Sandbox site. Open gallery. Navigate through slides. Close gallery. Hit back button. Gallery should not open. **Bonus feature** Single images linked to the attachment URL should now open in a lightbox. via #5469 Reviewers: samhotchkiss, dereksmart, eliorivero Reviewed By: dereksmart, eliorivero Differential Revision: https://[private link] Merges r147170-wpcom. * Carousel: merge changes from Jetpack Summary: This merges this commit to the css file - adbde22 It also includes manual resolution for the divergent files: - `mu-plugins/carousel/jetpack-carousel.php` - significant commits: - #5469 - 728c96f - 4b70301 - 7fc7ebd - b4ad963 - adbde22 - `mu-plugins/carousel/jetpack-carousel.js` - significant commits: - #8329 - #7943 - #8509 Test Plan: Steps: - Add an gallery widget to a site. - Click on an image in the gallery - The carousel should open and the navigation should work as expect. - Check the dev console for any JS errors Reviewers: dereksmart, zinigor Reviewed By: zinigor Subscribers: zinigor, brbrr, dereksmart Differential Revision: https://[private link] Merges r174217-wpcom. * Whitespace * whitespace * whitespace
jeherve
removed
the
[Status] Needs Testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minifies javascript for more modules.
Running tally:
Results
While it's hard (and not always useful) to generalise regarding performance, on a typical page with a bunch of features enabled - contact form, carousel, related posts, videopress, etc - these changes can shave around 25% off the total javascript payload.
Most of these files achieved a compression ratio of about 50%.
To get even better results, we should look at reducing the size of hosted JS, for example removing jQuery from the Likes widget. This would shave another 100kb or so from every (uncached) page load.