Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: adjust query boosting, add recency filter, and minor refactoring #8621

Merged
merged 2 commits into from Jan 26, 2018

Conversation

gibrown
Copy link
Member

@gibrown gibrown commented Jan 26, 2018

Fixes #8590

  • Adjusts what fields we boost on when running our queries (now I really want an all_content field)
  • Adds separate groups of fields for boosting on. All of the boosting is very ad-hoc. Needs more data and testing rather than this hand tuned mess
  • Fixes a bug where the default search query was not working if the site had a VIP index (requires adding define( 'JETPACK_SEARCH_VIP_INDEX', true ) as proposed in Search: max_offset is wrong in multiple ways #8560 )
  • Added a filter for adjusting the recency scoring as discussed in Search: add filters to allow customization of the search algorithm #7975 cc @jeherve
  • I looked at adding other filters, but feels like the other parts of the alg are likely to change too much.
  • Cleaned up some code, and made some vars and functions protected

@mdbitz @nickdaugherty the VIP index bug was pretty big here. Also, I think we had broken any cases where query_fields was used to over ride the fields. If you have any real sites set up, looking at the actual query results quality with and without this would be good too.

@gibrown gibrown added [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Pri] High [Feature] Search For all things related to Search labels Jan 26, 2018
@gibrown gibrown added this to the 5.8 milestone Jan 26, 2018
@gibrown gibrown self-assigned this Jan 26, 2018
@Viper007Bond Viper007Bond merged commit 1e73fee into master Jan 26, 2018
@Viper007Bond Viper007Bond deleted the update/search-query-and-filtering branch January 26, 2018 02:28
@jeherve jeherve removed [Status] Needs Review To request a review from Crew. Label will be renamed soon. [Status] Needs Changelog labels Jan 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Search For all things related to Search [Pri] High
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants