Modules: Confirm array is present#9245
Merged
Merged
Conversation
After d2fc8b9 , some sites were seeing warnings: Warning: in_array() expects parameter 2 to be array, null given in /home/public_html/wp-content/plugins/jetpack/class.jetpack.php on line 1518 It appears we should be
kraftbj
added
Bug
oskosk
previously requested changes
Apr 6, 2018
| // get available features | ||
| foreach ( self::get_available_modules() as $module_slug ) { | ||
| $module = self::get_module( $module_slug ); | ||
| if ( ! isset( $module ) || ! is_array( $module ) { |
Contributor
There was a problem hiding this comment.
Missing parens closing the whole if condition here
Contributor
|
@kraftbj I pushed a commit adding the missing parens so tests can run again |
Contributor
|
Good catch! Sorry about the warning. |
oskosk
added
[Status] Needs Changelog
[Status] Ready to Merge
ghost
removed
the
[Status] Ready to Merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After d2fc8b9 , some sites were seeing warnings:
It appears we should be setting a default
array('free')if there are no headers present, so I am not sure where this failure is coming from. This would prevent the warning.cc: @gravityrail