Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Membership Block #9802
This is the first PR of the block that is intended to provide something that beta users can test. We intend to work in small iterations and we will gladly address feedback in later PRs.
This introduces membership-button block to Jetpack.
Purpose of the code in this PR is to:
Testing instructions - Jurassic Ninja
The problem with this is that you can only use real money and real stripe accounts. If you want sandbox payments, you need to use the ngrok flow
Testing instructions - Jetpack Docker
@artpi there are a few JS linting messages on the test runs:
requested review from
Mar 27, 2019
This is an automated check which relies on
jeherve left a comment
Just a few minor comments, I have not had the time to fully test this yet.
Also, and since we are introducing a bunch a new files, what do you think about adding them all to the pre-commit hook here in Jetpack?
We've been trying to do that for all new files to slowly move towards better code coverage in the plugin.
jeherve left a comment
Let's merge this now and address the feedback in future PRs.
This matches the following error on WordPress.com:
Apr 29, 2019
referenced this pull request
May 1, 2019
I'm not wanting to go down the coding rabbit hole any more, but here's an innertubes show for ya to see and watch what happens:
After the "You ain't connected to the Packs de La Jets" prompt, the "Connect to Stripe" button can't be clicked at all.
I turned on my Beta Blockers and loaded up the Gutenberries as well
So, I decided to retry the Stripes, the Memberships, The Guttenberries, and the PacksOfJets again at 00:36 & still nothing https://youtu.be/SNxLOaHWAt8?t=36
@BurlesonBrad That error message should be displayed when the user you are logged in with is not linked to any WordPress.com account.
When you originally connected your site to WordPress.com, you did so while logged in as an admin on your site. If another admin wants to use the Memberships block, they'll need to link their own account to WordPress.com first. Does that make sense, and apply to you here, or do you see that error message while logged in with the admin account you used when you first connected your site to WordPress.com?
If the error appears even though the account you are currently logged in with is linked to WordPress.com, could you contact us via this form so we can run more tests with you and get this fixed?