Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AWS_KEY
andAWS_SECRET
env vars usingtravis encrypt
for the original repo, see https://docs.travis-ci.com/user/encryption-keys/See https://travis-ci.org/Srokap/knox for the tests running on my fork.
See https://coveralls.io/github/Srokap/knox for how the coveralls integration looks like.
For testing I chose oldest branch I was able to run tests on (the 0.8 defined in package.json was failing on
npm install
), LTS and current version which is 6. For now we run them in series, so didn't want to add more than I felt was necessary. If we created separate buckets for them, they could run in parallel.