Fix redirection to active #193

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
5 participants

rosbo commented Mar 27, 2013

The kue app has no knowledge of where it was mounted. Thus, we can't assume that '/active' is the right path.

For example, if we use path mouting:
app.use '/kue', kue.app

If we go to /kue, it redirects to /active instead of kue/active

rosbo referenced this pull request Mar 27, 2013

Merged

Fix redirection to /active #190

temsa commented Mar 31, 2013

+1, just happened to me, got to make the redirect by hand before making the app.use('/path', kue.app) line in my main code ...

Contributor

jackdbernier commented Mar 31, 2013

Using res.redirect('active') redirect me to http://active/ when I go to http://localhost/ which is not better. So another alternative should be use to solve the problem.

I'm using express 3.0.6 with kue 0.6.0

temsa commented Mar 31, 2013

maybe using "./active" ? else it could be done using the req path

2013/3/31 Jacques-Olivier D. Bernier notifications@github.com

Using res.redirect('active') redirect me to http://active/ which is not
better. So another alternative should be use to solve the problem.


Reply to this email directly or view it on GitHubhttps://github.com/LearnBoost/kue/pull/193#issuecomment-15690863
.

Contributor

jackdbernier commented Apr 3, 2013

See #195 I used req.app.route

Contributor

drudge commented Apr 3, 2013

This should be fixed in 0.6.2.

drudge closed this Apr 3, 2013

I'm still getting incorrect behaviour in Kue 0.6.2 and Express 3.2.5.

var kueApp = express();
kueApp.use(kue.app);
kueApp.listen(4000);

http://localhost:4000 redirects me to http://active

Changing to kueApp.use('/path', kue.app)as suggestued by @temsa works though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment