Remove timestamp from mongoose options #3649

Open
yordis opened this Issue Dec 5, 2015 · 6 comments

Comments

Projects
None yet
3 participants
@yordis

yordis commented Dec 5, 2015

Use the approach of plugins and create a repository for this functionality.

@vkarpov15

This comment has been minimized.

Show comment
Hide comment
@vkarpov15

vkarpov15 Dec 5, 2015

Collaborator

Thanks for the suggestion, I've been thinking about this myself. Should probably be a plugin. I think for now we'll just refactor it out to be a plugin internally and then turn the plugin off by default in 5.0.

Collaborator

vkarpov15 commented Dec 5, 2015

Thanks for the suggestion, I've been thinking about this myself. Should probably be a plugin. I think for now we'll just refactor it out to be a plugin internally and then turn the plugin off by default in 5.0.

@vkarpov15 vkarpov15 added this to the 4.4 milestone Dec 5, 2015

@yordis

This comment has been minimized.

Show comment
Hide comment
@yordis

yordis Dec 5, 2015

@vkarpov15 I think is a good idea even create two plugins for this. One for createdAt and the other for the updatedAt. This way we plug in just the necessary plugin.

yordis commented Dec 5, 2015

@vkarpov15 I think is a good idea even create two plugins for this. One for createdAt and the other for the updatedAt. This way we plug in just the necessary plugin.

@vkarpov15

This comment has been minimized.

Show comment
Hide comment
@vkarpov15

vkarpov15 Dec 6, 2015

Collaborator

You're right. In hindsight, adding this into core mongoose was a little shortsighted since it's really easy to add as a plugin. The reason why we added it was that this was a commonly requested feature and putting it as a plugin is a bit of a barrier to entry since many users don't really understand how to use plugins, but we should just work on making plugins more accessible.

Collaborator

vkarpov15 commented Dec 6, 2015

You're right. In hindsight, adding this into core mongoose was a little shortsighted since it's really easy to add as a plugin. The reason why we added it was that this was a commonly requested feature and putting it as a plugin is a bit of a barrier to entry since many users don't really understand how to use plugins, but we should just work on making plugins more accessible.

@yordis

This comment has been minimized.

Show comment
Hide comment
@yordis

yordis Dec 7, 2015

@vkarpov15 yeah, at this point I support the idea of them having question and we help them to understand the tech instead of create shortcuts for them 😄

yordis commented Dec 7, 2015

@vkarpov15 yeah, at this point I support the idea of them having question and we help them to understand the tech instead of create shortcuts for them 😄

@simnare

This comment has been minimized.

Show comment
Hide comment
@simnare

simnare Dec 9, 2015

@yordis i think single plugins is enough, simple config option to disable updated timestamp is a better approach imho

simnare commented Dec 9, 2015

@yordis i think single plugins is enough, simple config option to disable updated timestamp is a better approach imho

@vkarpov15 vkarpov15 modified the milestones: 4.6, 4.5 Feb 19, 2016

@yordis

This comment has been minimized.

Show comment
Hide comment
@yordis

yordis Aug 8, 2016

@simnare which ever is the case it's fine as long as we created a package for those things

yordis commented Aug 8, 2016

@simnare which ever is the case it's fine as long as we created a package for those things

@vkarpov15 vkarpov15 modified the milestones: 4.11, 4.8 Dec 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment