New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support change detection for in-place updates to date objects? #3738

Closed
vkarpov15 opened this Issue Jan 6, 2016 · 4 comments

Comments

Projects
None yet
3 participants
@vkarpov15
Collaborator

vkarpov15 commented Jan 6, 2016

For instance doc.createdAt.setDate(2011, 5, 1); should get saved to the db without needing to call .markModified(), re #3722. Discussions and +1's welcome.

@vkarpov15 vkarpov15 added the discussion label Jan 6, 2016

@TrejGun

This comment has been minimized.

Show comment
Hide comment
@TrejGun

TrejGun Jan 11, 2016

Contributor

are you going to call setter too?

Contributor

TrejGun commented Jan 11, 2016

are you going to call setter too?

@vkarpov15

This comment has been minimized.

Show comment
Hide comment
@vkarpov15

vkarpov15 Jan 11, 2016

Collaborator

That would be ideal. Not planning on supporting this behavior unless there's a lot of demand though, you don't really see people using in-place updates on dates that often in my experience.

Collaborator

vkarpov15 commented Jan 11, 2016

That would be ideal. Not planning on supporting this behavior unless there's a lot of demand though, you don't really see people using in-place updates on dates that often in my experience.

@stableShip

This comment has been minimized.

Show comment
Hide comment

+1

@vkarpov15

This comment has been minimized.

Show comment
Hide comment
@vkarpov15

vkarpov15 Sep 26, 2017

Collaborator

Going to close this unless there's very strong objections. Too many caveats, not much value, especially since we have this in the FAQ.

Collaborator

vkarpov15 commented Sep 26, 2017

Going to close this unless there's very strong objections. Too many caveats, not much value, especially since we have this in the FAQ.

@vkarpov15 vkarpov15 closed this Sep 26, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment