Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): use correct Query constructor when cloning query #12418

Merged
merged 1 commit into from Sep 12, 2022

Conversation

vkarpov15
Copy link
Collaborator

@vkarpov15 vkarpov15 commented Sep 11, 2022

Fix #12365

Summary

#12365 pointed out that we're not cloning hooks correctly. That's because this.constructor doesn't seem to pick up the correct Query class - it picks up the default Query, not the model-specific Query.

Examples

Copy link
Collaborator

@AbdelrahmanHafez AbdelrahmanHafez left a comment

LGTM, thanks 👍

@vkarpov15 vkarpov15 merged commit 805c927 into master Sep 12, 2022
36 checks passed
@vkarpov15 vkarpov15 deleted the vkarpov15/gh-12365 branch Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clone Query ignores hooks
2 participants