types: correctly handle union types in BufferToBinary and related helpers#15103
Merged
types: correctly handle union types in BufferToBinary and related helpers#15103
Conversation
hasezoey
approved these changes
Dec 18, 2024
Collaborator
hasezoey
left a comment
hasezoey
left a comment
There was a problem hiding this comment.
LGTM, can confirm this version passes all typegoose tests and does not require modification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #15057
Replacement for #15072
Summary
This looks to be a more correct approach than #15072, which had some unexpected issues that @hasezoey pointed out. @hasezoey can you please double check whether this causes issues for Typegoose?
Examples