Merged
Conversation
hasezoey
reviewed
Dec 19, 2024
Collaborator
hasezoey
left a comment
hasezoey
left a comment
There was a problem hiding this comment.
Looks good to me, though is when going directly to that endpoint(/.netlify/functions) supposed to show "Page not found" (though adding /search gives a parameter error)?
Also when trying to run this locally, it seem to not work with the error:
Cross-Origin Request Blocked: The Same Origin Policy disallows reading the remote resource at https://mongoose-js.netlify.app/.netlify/functions/search?search=model&version=8.x. (Reason: CORS header ‘Access-Control-Allow-Origin’ missing). Status code: 200.
hasezoey
added
the
docs
Collaborator
Author
|
Thanks for catching that, there was a CORS issue on mongoosejs/backend that I fixed. Seems to work fine now, I can
|
Collaborator
|
Can confirm that it also now works when using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I refactored https://github.com/mongoosejs/backend to run on Netlify functions because I was having a lot of trouble with deploying to Azure Functions. Netlify's automatic CI/CD should make it much easier to maintain the backend going forward.
I will have to make this change in other branches. However not urgent - the Azure Functions endpoint is still running and up to date, I just had to make some changes to our GitHub webhook re: #15117 so that's the only code that's out of date.
Examples