types(model+query): avoid stripping out virtuals when calling populate with paths generic#15132
Merged
types(model+query): avoid stripping out virtuals when calling populate with paths generic#15132
Conversation
…e with paths generic Fix #15111
AbdelrahmanHafez
approved these changes
Dec 28, 2024
hasezoey
approved these changes
Dec 28, 2024
Collaborator
hasezoey
left a comment
hasezoey
left a comment
There was a problem hiding this comment.
LGTM.
Some style changes to remove unrelated things from the types.
Co-authored-by: hasezoey <hasezoey@gmail.com>
Co-authored-by: hasezoey <hasezoey@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #15111
Summary
.populate<Paths>returns a hydrated document with no virtuals, because we're not passingTVirtualsinto queries. This PR fixes that by replacingTInstanceMethodswithTDocOverridessimilar to what we do forHydratedDocument- globbing together instance methods and virtuals into one "overrides" type that we&on to get the fully hydrated document.Examples