fix(schema): make duplicate index error a warning for now to prevent blocking upgrading#15135
Merged
fix(schema): make duplicate index error a warning for now to prevent blocking upgrading#15135
Conversation
AbdelrahmanHafez
approved these changes
Dec 28, 2024
hasezoey
approved these changes
Dec 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #15109
Re: #15112
Summary
The new duplicate index error has caused some headache for a lot of users, so in the interest of not blocking anyone from upgrading, I changed the error to a warning. That way there is an indication that duplicate indexes are a problem, and it should be only slightly more difficult to trace down the duplicate index because Node.js warnings can get stack traces with the
--trace-warningscommand line flag.Examples