Fix document not applying manual populate when using a function in schema.options.ref#15138
Merged
vkarpov15 merged 2 commits intoAutomattic:masterfrom Jan 4, 2025
Merged
Conversation
vkarpov15
approved these changes
Jan 4, 2025
Collaborator
vkarpov15
left a comment
There was a problem hiding this comment.
I made a couple of minor changes to make this more consistent with ref function checks in other places, but otherwise LGTM. I'll add a test after merging.
vkarpov15
added a commit
that referenced
this pull request
Jan 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Schema.options.ref works with functions but it doesn't mark the path as populated if done manually when creating a new document or assigning to a property.
Examples