toConstructor() working & sort fixes #1609

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
2 participants
Contributor

ebensing commented Aug 1, 2013

Unfortunately, my work on fixing sort kinda got mixed up in this since it only came up because of the toConstructor() method.

Those changes can be summed up as "now storing sort information in an object instead of an array"

The to constructor stuff works just like it does in mquery.

ebensing referenced this pull request Aug 1, 2013

Closed

expose mquery toConstructor #1600

2 of 2 tasks complete

ebensing added some commits Jul 30, 2013

@ebensing ebensing inital work on toConstructor in mongoose, needs tests caa309e
@ebensing ebensing toConstructor() working and tests written
passing all tests. Additional fixes for dealing with `sort` passed via
`setOptions` Moral of the story: the storage format for sort sucks
9ad0291
@ebensing ebensing Updated mquery version, removed sort hacks
Updated to new mquery version which gets rid of the terrible internal
sort syntax.
5368d4b
@ebensing ebensing Fixed call signature of custom query call to super
Hadn't switched it from the old Query constructor syntax
953343d
Collaborator

aheckmann commented Aug 19, 2013

merged!

aheckmann closed this Aug 19, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment